ZCU-DATA added to trigger ui tests #934
Conversation
WalkthroughThis change updates the UI test workflow configuration by removing "customer/zcu-data" from the list of branches excluded from triggering UI tests. As a result, UI tests will now run for the "customer/zcu-data" branch, while "customer/sav" and "customer/vsb-tuo" remain excluded. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/trigger-ui-tests.yml (1)
27-33: Skip list now hard-coded in two places – consider centralising to avoid driftThe removal of
customer/zcu-datameets the goal of enabling tests for that branch 👍.
Going forward, the skip list (SKIP_BRANCHES) is likely to evolve. Keeping it embedded here means every customer branch maintains its own copy (see learning note), increasing maintenance overhead and risk of divergence.Suggestion: expose the list as an input to the workflow (
workflow_call->inputs.skip_branches) and default to the current values. Each customer branch can then override the value in its caller workflow without touching this file.No action required for this PR; just a maintainability consideration.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/trigger-ui-tests.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: Kasinhou
PR: dataquest-dev/dspace-angular#905
File: .github/workflows/automated-manual-tests.yml:24-33
Timestamp: 2025-07-09T12:50:03.144Z
Learning: In the dspace-angular project, customer-specific GitHub workflow files like `.github/workflows/automated-manual-tests.yml` are maintained separately in each customer branch with hard-coded values appropriate for that customer, rather than using parameterized workflows. This allows each customer branch to have its own configuration while avoiding the complexity of workflow parameterization.
.github/workflows/trigger-ui-tests.yml (1)
Learnt from: Kasinhou
PR: #905
File: .github/workflows/automated-manual-tests.yml:24-33
Timestamp: 2025-07-09T12:50:03.144Z
Learning: In the dspace-angular project, customer-specific GitHub workflow files like .github/workflows/automated-manual-tests.yml are maintained separately in each customer branch with hard-coded values appropriate for that customer, rather than using parameterized workflows. This allows each customer branch to have its own configuration while avoiding the complexity of workflow parameterization.
Problem description
Reported issues
Not-reported issues
Analysis
(Write here, if there is needed describe some specific problem. Erase it, when it is not needed.)
Problems
(Write here, if some unexpected problems occur during solving issues. Erase it, when it is not needed.)
Summary by CodeRabbit