[CFX-5560] chore: new task delint to fix lints#422
Merged
ajalon1 merged 5 commits intodatarobot-oss:mainfrom Apr 8, 2026
Merged
[CFX-5560] chore: new task delint to fix lints#422ajalon1 merged 5 commits intodatarobot-oss:mainfrom
ajalon1 merged 5 commits intodatarobot-oss:mainfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit b228122. Configure here.
Contributor
c-h-russell-walker
left a comment
There was a problem hiding this comment.
Very nice - thank you for this.
Question though - won't linting in CI pass even if there's then unstaged changes?
Maybe make an additional task command called like delint or lint-fix ?
Contributor
Author
|
Great point. I was wondering why we didn't have a Let me pull this back into draft and add a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

RATIONALE
I want a way to fix as many lint issues as possible.
lintdoes some already, but I know golangci-lint can fix issues, so let's do that too.Let's actually do that in a new
delinttask, and leavelintas is.CHANGES
task delint
golangci-lint run --fix
simplify AGENTS.md
update dev docs
PR Automation
Comment-Commands: Trigger CI by commenting on the PR:
/trigger-smoke-testor/trigger-test-smoke- Run smoke tests/trigger-install-testor/trigger-test-install- Run installation testsLabels: Apply labels to trigger workflows:
run-smoke-testsorgo- Run smoke tests on demand (only works for non-forked PRs)Important
For Forked PRs: If you're an external contributor, the
run-smoke-testslabel won't work. A maintainer must manually trigger the "Fork PR Smoke Tests" workflow from the Actions tab, providing your PR number. Please comment requesting a maintainer review if you need smoke tests to run.Note
Low Risk
Low risk: changes are limited to developer tooling/docs and do not affect runtime CLI behavior. Main impact is local/CI workflows now using
task lintfor non-modifying checks andtask delintfor auto-fixes.Overview
Splits linting into check-only
task lintand auto-fixingtask delint, makinglintnon-modifying (usesgo mod tidy -diff,gofumpt -d,golangci-lint run, andgoreleaser check) whiledelintruns formatting/dependency cleanup andgolangci-lint run --fix.Updates
dev-initto depend ondelintand refreshesAGENTS.mdto document the new task semantics and recommended workflow (rundelintto fix, thenlintto verify).Reviewed by Cursor Bugbot for commit d28716d. Bugbot is set up for automated code reviews on this repo. Configure here.