This repository was archived by the owner on Sep 9, 2020. It is now read-only.
PRED-2176 refactor format_data to use generators approach #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devexp-slackbot
bot
added
Ready for Review
Needs Review: Predictions
and removed
Ask for Review on Green
labels
chrj
reviewed
Mar 19, 2019
| row_generator: iterator | ||
| """ | ||
| headers = [] | ||
| single_row = result_sorted[0] |
There was a problem hiding this comment.
Will there always be at least one item in result_sorted? Otherwise this could raise an IndexError.
Contributor
Author
There was a problem hiding this comment.
Yes, there's a check that forbids sending empty dataset for scoring much earlier
https://github.com/datarobot/batch-scoring/blob/master/datarobot_batch_scoring/reader.py#L255
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BATCH SCORING PULL REQUEST
This is a pull request into a public repository for Batch Scoring script maintained by DataRobot.
RATIONALE
The structure of
datarobot_batch_scoring.api_response_handlers.pred_api_v10.format_datafunction makes it difficult to understand the code and add new columns.CHANGES
format_datawas refactored in favor of generators approach.TESTING