Introduce Enhanced Q-Q Plot Support for Distribution GOF Diagnostics#111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to make distributional goodness-of-fit diagnostics more expressive, statistically correct, and easier to interpret when comparing multiple candidate distributions.
Key Features
1. Theoretical and Empirical Q-Q Plots
qq_typeparameter.2. Optional Reference Line Control
show_reference=True|False.3. Multi-Distribution Overlay Support
palettemapping.4. Axis Scaling and Limits
xlimandylimparameters allow users to enforce consistent axis ranges across distributions.5. Defensive Validation
reference_data.API Additions
New or updated parameters in
distribution_gof_plots():qq_type: {"theoretical", "empirical"}reference_data: np.ndarray | Noneshow_reference: boolxlim: tuple[float, float] | Noneylim: tuple[float, float] | Nonepalette: dict[str, str] | NoneInternal Refactoring
_qq_plot()helper with a focused responsibility:plots.pyby making helper intent explicit.Design Notes
Backward Compatibility
distribution_gof_plots()withplot_types="qq"continues to work with default behavior.Example