fix: Windows copy-paste, resize debounce, CLI upgrades#72
Merged
datasciencemonkey merged 5 commits intodatasciencemonkey:mainfrom Mar 24, 2026
Merged
fix: Windows copy-paste, resize debounce, CLI upgrades#72datasciencemonkey merged 5 commits intodatasciencemonkey:mainfrom
datasciencemonkey merged 5 commits intodatasciencemonkey:mainfrom
Conversation
Prevents fitAddon.fit() from thrashing scroll position on every resize pixel. Adds explicit scrollback and scrollOnUserInput. Co-authored-by: Isaac
Previously skipped install if binary existed, leaving stale versions across redeployments. Co-authored-by: Isaac
xterm.js intercepts Ctrl+V/C as raw control characters on non-Mac platforms. Added attachCustomKeyEventHandler to let the browser handle Ctrl+V (paste), Ctrl+C (copy when text selected), and Ctrl+Shift+C/V. Also added clipboard section to shortcuts help with platform-aware labels (Cmd on Mac, Ctrl on Windows) and upload toast for image paste. Co-authored-by: Isaac
Runtime image ships an older CLI (v0.251.0). Added a setup step that fetches the latest release from GitHub API and installs it to ~/.local/bin, same pattern as the GitHub CLI install. Co-authored-by: Isaac
4 tasks
mpkrass7
reviewed
Mar 17, 2026
mpkrass7
reviewed
Mar 17, 2026
Move inline bash from app.py into install_gh.sh and install_databricks_cli.sh, matching the install_micro.sh pattern. The gh script now fetches the latest version dynamically instead of hardcoding v2.74.1, and fixes a bug in the auth wrapper where the `gh auth login` handler fell through to `exec gh.real "$@"` with shifted args (added `exit 0`). Co-authored-by: Isaac
Collaborator
|
@dgokeeffe Let me know when you've deployed / tested your changes on dogfood. Once you confirm I'll test on my end and we can get this merged. |
Owner
|
Testing this on Databricks Apps — merged cleanly with current main (including session linger, FD leak fix, and upload limit from PR #77). All existing tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
attachCustomKeyEventHandlerto xterm.js so Ctrl+C/V work on Windows (previously intercepted as raw terminal control chars)Test plan
gh auth loginworks through the PTY wrapperThis pull request was AI-assisted by Isaac.