Conversation
- ResourceTask.java: introduce 0th index so lastIndexOf() can be used consistently in Form.js to separate ids and indices - readTaskInputsFromForm(): process task input if their index-less id has the same value as the id generated - appendInputRowAfter(): only consider inputs to append if their index-less id has the same value as the id given as a parameter. Id is given by the remainder of the string after the last "|" separator Signed-off / re-signed by committer
- added a new toIdWithoutIndex function to reduce duplicate code
hhund
force-pushed
the
issue/442_form_js_builds_invalid_Task_resource_when_submitting_form
branch
from
8e67454 to
7fb05ad
Compare
Member
|
I had to rebase and force push to have the first commit also be signed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #442 .