Updated 'nfilter' use

[StuartWheater]

Change from using 'setFilterDS' to 'listDisclosureSettingsDS'.

[OllyButters]

@pb51 @davraam - could one of you have a look at this? @StuartWheater has updated some of the disclosure settings and could do with someone else having a quick look at it.

[davraam]

@pb51 @davraam - could one of you have a look at this? @StuartWheater has updated some of the disclosure settings and could do with someone else having a quick look at it.

The changes look ok to me.

[OllyButters]

Thanks @davraam

[pb51]

Hi Stuart, Olly, Demetris, Hasan Because I was worried about the non-standard way meanSdGp was enacting its disclosure tests, I downloaded Stuart's version down from his GitHub repo and have prepared a more formal QA script (this was one of the earliest of my functions [2015] and I didn't prepare a proper QA script). However, it passes all checks of function and disclosure failure, and so I am happy for it to all to be merged. By the way, in doing this I think I now know the best way to test that the disclosure traps work properly during QA testing and I'll speak to Stuart, Demetris and Hasan about this later in the week. Is Hasan on this mailing list too? Cheers Paul

…

On Tue, Dec 10, 2019 at 10:05 AM Stuart Wheater ***@***.***> wrote: Change from using 'setFilterDS' to 'listDisclosureSettingsDS'. ------------------------------ You can view, comment on, or merge this pull request online at: #35 Commit Summary - Updated 'nfilter' use File Changes - *M* R/cDS.R <https://github.com/datashield/dsBase/pull/35/files#diff-0> (12) - *M* R/isValidDS.R <https://github.com/datashield/dsBase/pull/35/files#diff-1> (18) - *M* R/meanSdGpDS.R <https://github.com/datashield/dsBase/pull/35/files#diff-2> (16) - *M* R/subsetByClassDS.R <https://github.com/datashield/dsBase/pull/35/files#diff-3> (18) - *M* R/subsetDS.R <https://github.com/datashield/dsBase/pull/35/files#diff-4> (16) - *M* R/table1DDS.R <https://github.com/datashield/dsBase/pull/35/files#diff-5> (16) Patch Links: - https://github.com/datashield/dsBase/pull/35.patch - https://github.com/datashield/dsBase/pull/35.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#35?email_source=notifications&email_token=ABAW4OKNNCBNMXUKOHX47L3QX5SVNA5CNFSM4JY3ZL32YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H7M6FIQ>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABAW4OJDBONPWCPRTS2YKD3QX5SVNANCNFSM4JY3ZL3Q> .

-- *********************************************************************************************************** *Paul Burton, Professor of Data Science for Health* D2K Research Group, Institute of Health and Society, Newcastle University, Baddiley-Clark Building, Richardson Road, Newcastle upon Tyne, NE2 4AX, United Kingdom Telephone (for IHS): (0)191 208 7045 Email: paul.genepi@gmail.com ************************************************************************************************************