Replace test for Apple Mx processors#422
Merged
StuartWheater merged 1 commit intodatashield:v6.3.4-devfrom Aug 23, 2025
Merged
Conversation
…, this test is based on observed behaviour for the stats::cor and stats::cor.test functions, where the approximation for the correlation for some vectors is nearly 1, resulting in 1 - cor(x, y) > 0, when the expected value should be 0. For example, when x = y = c(0.0, 3.0, 7.0)
Member
|
Thanks, will create RC4 tomorrow (probably), and will include "Replace test for Apple Mx process ..." text in the notes to the CRAN. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v6.3.4-dev #422 +/- ##
===========================================
Coverage 29.42% 29.42%
===========================================
Files 138 138
Lines 5729 5729
===========================================
Hits 1686 1686
Misses 4043 4043 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace test for Apple Mx processors without assumptions of tolerance,
this test isthese tests are based on observed behaviour for thestats::corandstats::cor.testfunctions, where the approximation for the correlation for some vectors is nearly 1, resulting in1 - cor(x, y) > 0, when the expected value should be 0. For example, whenx = y = c(0.0, 3.0, 7.0)