This repository was archived by the owner on Mar 3, 2026. It is now read-only.
Merged
Conversation
bjchambers
reviewed
Jun 14, 2023
9e0386c to
be0bafe
Compare
epinzur
approved these changes
Jun 16, 2023
bjchambers
reviewed
Jun 16, 2023
bjchambers
reviewed
Jun 16, 2023
bjchambers
approved these changes
Jun 16, 2023
Collaborator
bjchambers
left a comment
There was a problem hiding this comment.
Seems fine for getting things moving.
Ideally, we'd either introduce an enum for the boolean or we'd simplify things so we didn't need to pass it (possibly deciding based on the presence of the _publish_time field in the schema that we need to add it). If we did the enum, it would let us write something PublishTime::Add or PublishTime::None rather than true and false, which would make it clearer what the booleans mean, especially in the cases of the functions that take multiple booleans.
be0bafe to
e81d5b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR with the progress made towards debugging the streaming implementation.
Changes: