Skip to content

feat: Prototype of RLAC on Documents#237

Merged
erichare merged 4 commits into
mainfrom
feat/rlac-prototype
May 15, 2026
Merged

feat: Prototype of RLAC on Documents#237
erichare merged 4 commits into
mainfrom
feat/rlac-prototype

Conversation

@erichare
Copy link
Copy Markdown
Collaborator

This pull request adds full support for RLAC (Row-Level Access Control) visibility and ownership metadata to the document management UI. It introduces the ability to view and edit document visibility, display document owners, and replace document files, all gated by workspace-level RLAC enablement. The changes also update test mocks and test data to accommodate the new fields.

RLAC Visibility and Ownership Support

  • Added RLAC-aware fields (visibleTo, ownerPrincipalId) to document records and test data throughout the codebase, ensuring consistent handling of document visibility and ownership. [1] [2] [3] [4] [5] [6]
  • Updated test mocks to provide RLAC-related hooks and data, ensuring tests remain valid with the new fields. [1] [2] [3]

Document Table and Detail Enhancements

  • Modified DocumentTable to display a "Visible to" column with chips for each principal when RLAC is enabled, and added a pencil (edit) button to open the edit dialog. [1] [2] [3] [4] [5]
  • Updated DocumentDetailDialog to show the document's owner and include an inline VisibilityEditor for adjusting document visibility when RLAC is active. [1] [2] [3] [4]

Document Editing and Replacement

  • Introduced a new EditDocumentDialog component for editing document metadata (name and visibility) and replacing the file contents, with separate flows for metadata patching and file replacement.

These changes collectively enhance the document management experience by providing granular visibility controls and making document metadata and ownership transparent and editable when RLAC is enabled.

Comment thread runtimes/typescript/src/routes/api-v1/kb-documents.ts Fixed
Comment thread runtimes/typescript/tests/policy/routes.test.ts Fixed
erichare and others added 3 commits May 14, 2026 17:58
…tion or class'

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…ariable'

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
@erichare erichare merged commit e55f6c7 into main May 15, 2026
11 of 12 checks passed
@erichare erichare deleted the feat/rlac-prototype branch May 15, 2026 01:08
erichare added a commit that referenced this pull request Jun 3, 2026
* Push doc updates

* Potential fix for pull request finding 'Unused variable, import, function or class'

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

* Potential fix for pull request finding 'Useless assignment to local variable'

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

* chore: Biome and lint ch4eck

---------

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant