feat: Prototype of RLAC on Documents#237
Merged
Merged
Conversation
…tion or class' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…ariable' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
erichare
added a commit
that referenced
this pull request
Jun 3, 2026
* Push doc updates * Potential fix for pull request finding 'Unused variable, import, function or class' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * Potential fix for pull request finding 'Useless assignment to local variable' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * chore: Biome and lint ch4eck --------- Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds full support for RLAC (Row-Level Access Control) visibility and ownership metadata to the document management UI. It introduces the ability to view and edit document visibility, display document owners, and replace document files, all gated by workspace-level RLAC enablement. The changes also update test mocks and test data to accommodate the new fields.
RLAC Visibility and Ownership Support
visibleTo,ownerPrincipalId) to document records and test data throughout the codebase, ensuring consistent handling of document visibility and ownership. [1] [2] [3] [4] [5] [6]Document Table and Detail Enhancements
DocumentTableto display a "Visible to" column with chips for each principal when RLAC is enabled, and added a pencil (edit) button to open the edit dialog. [1] [2] [3] [4] [5]DocumentDetailDialogto show the document's owner and include an inlineVisibilityEditorfor adjusting document visibility when RLAC is active. [1] [2] [3] [4]Document Editing and Replacement
EditDocumentDialogcomponent for editing document metadata (name and visibility) and replacing the file contents, with separate flows for metadata patching and file replacement.These changes collectively enhance the document management experience by providing granular visibility controls and making document metadata and ownership transparent and editable when RLAC is enabled.