Skip to content

fix: Properly slice the line between backslashes#293

Merged
erichare merged 2 commits intodatastax:mainfrom
erichare:fix-off-by-one
Mar 17, 2026
Merged

fix: Properly slice the line between backslashes#293
erichare merged 2 commits intodatastax:mainfrom
erichare:fix-off-by-one

Conversation

@erichare
Copy link
Copy Markdown
Collaborator

Fixes #292

This pull request fixes a bug in the readStdin method related to how lines ending with a backslash are handled. Specifically, it corrects the substring range so that the backslash character is properly excluded from the appended result.

  • Bug fix in input reading:
    • Corrected the substring range in the readStdin method of CqlshStartImpl.java to exclude the trailing backslash from lines ending with This pull request fixes a bug in the readStdin` method related to how lines ending with a backslash are handled. Specifically, it corrects the substring range so that the backslash character is properly excluded from the appended result.

Copy link
Copy Markdown
Member

@msmygit msmygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@erichare erichare merged commit fc0da82 into datastax:main Mar 17, 2026
@erichare erichare deleted the fix-off-by-one branch March 17, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Off-by-one issue in CQL stdin multiline parsing

2 participants