Initial draft of find / find one #8

a-random-steve · 2025-03-24T21:47:16Z

No description provided.

…ology, switch integrations tests to xunit, begin adding db administration methods

…ions tree

Db admin - initial commit

added ListDatabases, ListDatabasesNames and tests

added DoesDatabaseExist by string and by guid

…check, and list collections, rounding out create collection methods

Database admin

# Conflicts: # src/DataStax.AstraDB.DataAPI/Core/DatabaseOptions.cs # src/DataStax.AstraDB.DataApi/Admin/AstraDatabasesAdmin.cs # src/DataStax.AstraDB.DataApi/Admin/CloudProviderType.cs # src/DataStax.AstraDB.DataApi/Collections/Collection.cs # src/DataStax.AstraDB.DataApi/Core/CommandOptions.cs # src/DataStax.AstraDB.DataApi/Core/CommandUrlBuilder.cs # src/DataStax.AstraDB.DataApi/Core/Commands/Command.cs # src/DataStax.AstraDB.DataApi/Core/Database.cs # src/DataStax.AstraDB.DataApi/Core/DatabaseOptions.cs # src/DataStax.AstraDB.DataApi/Core/Extensions.cs # src/DataStax.AstraDB.DataApi/DataAPIClient.cs # src/DataStax.AstraDB.DataApi/Utils/Extensions.cs # src/DataStax.AstraDB.DataApi/Utils/Guard.cs # test/DataStax.AstraDB.DataApi.IntegrationTests/AdminFixture.cs # test/DataStax.AstraDB.DataApi.IntegrationTests/ClientFixture.cs # test/DataStax.AstraDB.DataApi.IntegrationTests/Tests/AdminTests.cs # test/DataStax.AstraDB.DataApi.IntegrationTests/Tests/CollectionTests.cs

# Conflicts: # src/DataStax.AstraDB.DataApi/Admin/DatabaseAdminNonAstra.cs # src/DataStax.AstraDB.DataApi/Collections/Collection.cs # src/DataStax.AstraDB.DataApi/Collections/CollectionInsertManyResult.cs # src/DataStax.AstraDB.DataApi/Core/Commands/Command.cs # src/DataStax.AstraDB.DataApi/Core/Extensions.cs # src/DataStax.AstraDB.DataApi/Core/Results/ListCollectionsResult.cs # src/DataStax.AstraDB.DataApi/Utils/Guard.cs

Initial draft of find / find many

toptobes · 2025-03-25T05:01:19Z

src/DataStax.AstraDB.DataApi/Core/InsertManyOptions.cs

+
+public class InsertManyOptions
+{
+    public const int MaxChunkSize = 50;


Try to avoid hardcoding Data API limits into the client (since they may change in the future, so it's best to just let the Data API deal with any limit issues)

Also, the Data API's batch size limit is currently 100, not 50 🙃. It's just recommended for the clients to keep it at 50 for better average performance

Ok, I was following the Java client there. I see the TS client defaults to 50 but doesn't enforce a max.

toptobes · 2025-03-25T05:14:11Z

src/DataStax.AstraDB.DataApi/Collections/Collection.cs

+        return new FluentFind<T, TId, TResult>(this, filter);
+    }
+
+    public Cursor<T> FindMany()


There is no findMany; just find (adhering with the Data API)

Also, creating a cursor (e.g. Collection.Find() should always be pure; no I/O should be performed until the cursor is actually used.

Meaning, the first page should only be fetched when a method like .Next(), .HasNext(), .ToArray(), etc. is called

Also it should be named CollectionFindCursor here, which should extend a base FindCursor, which in turn extends AbstractCursor (mermaid)

I've reworked the method naming, adjusted the calls to wait until the data is accessed. Will consider potential refactoring base cursor once we implement tables.

toptobes · 2025-03-25T05:15:10Z

src/DataStax.AstraDB.DataApi/Collections/Collection.cs

+        return response.Data.Document;
+    }
+
+    public FluentFind<T, TId, T> Find()


FluentFind's properties/methods should probably be parts of the FindCursor object itself

This is somewhat modified in the next merge.

toptobes · 2025-03-25T05:27:15Z

src/DataStax.AstraDB.DataApi/Collections/CollectionInsertManyResult.cs

-
-    T DeserializeFromMap<T>(Dictionary<string, object> map);
-}
+    public List<T> InsertedIds { get; internal set; } = new List<T>();


Should have an InsertedCount property as well

i.e.

public int InsertedCount => InsertedIds.Count;

toptobes · 2025-03-25T05:29:31Z

src/DataStax.AstraDB.DataApi/Core/ApiResponse.cs

 }

-internal class ApiResponseDictionary : Dictionary<string, object>
+internal class ApiResponseWithData<T, TStatus>


You may very well know this already, but just as a heads up that there may be a warnings field present as well, alongside data, status, and errors

warnings will have the exact same response shape as errors.

Only point of note is that the scope of a warning is always 'WARNING'

Thanks for the note, this has been added.

toptobes · 2025-03-25T05:37:30Z

src/DataStax.AstraDB.DataApi/Core/Query/FilterBuilder.cs

+
+namespace DataStax.AstraDB.DataApi.Core.Query;
+
+public class FilterBuilder<T>


There should probably be an escape hatch function for filter operators which may be added in the future (unless the escape hatch is creating a new Filter object manually, in which case, disregard)

Hmm, interesting consideration. Will think about.

stephenatsembit and others added 30 commits January 28, 2025 17:08

set ConfigureAwait(false) for async calls

ebba922

refactor command options, refactor naming, solidify sync/async method…

27e0cc1

…ology, switch integrations tests to xunit, begin adding db administration methods

add sample appsettings file, remove test file

012d71e

remove bin and obj folders, move defaults to proper end of commandopt…

7ad7210

…ions tree

add unittest bin/obj, and appsettings to ignore

37475b1

runnable state (renaming and test tweaks)

5da9ccc

rename, .gitignore, DbId for admin tests

6e14fe9

Merge pull request #1 from stephenatsembit/db_admin

01cd335

Db admin - initial commit

added ListDatabases, ListDatabasesNames and tests

4a09303

turn off implicit usings to make .net462 happy

0044e28

Merge pull request #2 from stephenatsembit/db_admin

c84088e

added ListDatabases, ListDatabasesNames and tests

added DoesDatabaseExist by string and by guid

23e7e3a

Merge pull request #3 from stephenatsembit/db_admin

114a373

added DoesDatabaseExist by string and by guid

formatting

6c9e310

todo for integration test to check for existence by name

6cb1cb4

utilizing CommandOptions to affect the http calls, adding methods to …

b4233e9

…check, and list collections, rounding out create collection methods

added create, drop; consistent naming

ae9082c

refs and formatting

de696d1

spacing

76d117a

move test db name into config

3f4b528

handle sync waitfordatabase

4d8614d

cleanup async methods

0ce4e10

refs and spacing

d2526fa

async delagte for CreateDatabase

ec11ccf

added DatabaseCreationOptions

c775326

remove t/s code

3024e03

added CommandOptions

4bd98d0

finish handling of keyspace for database, naming adjustments

d187fc1

Merge pull request #5 from stephenatsembit/database-admin

d102ea2

Database admin

stephenatsembit and others added 9 commits February 17, 2025 14:53

fix merge errors

e05da62

additional merge issues

4721ae1

beginnings of insert many

3456673

fix merge issue

46cf764

collection.InsertMany, and initial FindOne and FindMany implementations

dbb9cf6

FindOne fixes

ec14f98

finish initial draft of querying single and multiple documents

c211213

Merge pull request #6 from stephenatsembit/collection-insert-many

c27bf7a

Initial draft of find / find many

vkulichenko approved these changes Mar 24, 2025

View reviewed changes

vkulichenko merged commit 427586b into datastax:main Mar 24, 2025

toptobes reviewed Mar 25, 2025

View reviewed changes


		namespace DataStax.AstraDB.DataApi.Core.Query;

		public class FilterBuilder<T>

Initial draft of find / find one #8

Initial draft of find / find one #8

Uh oh!

Conversation

a-random-steve commented Mar 24, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

toptobes Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

toptobes Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

toptobes Mar 25, 2025 •

edited

Loading

toptobes Mar 25, 2025 •

edited

Loading