CNDB-15620: Fix sstablesHit and segmentsHit metrics to be updated by ANN and generic OrderBy #2115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ANN and generic OrderBy
Checklist before you submit for review
|
Author
|
This is ready for review, the test coverage complains about two assertions not being covered, but that would be a bug, so I think we are good from test coverage perspective. The only test failure has actually a ticket for the same one. It does not fail locally and I keep on seeing it also on other PRs today. |
adelapena
reviewed
Nov 12, 2025
test/distributed/org/apache/cassandra/distributed/test/sai/SlowSAIQueryLoggerTest.java
Outdated
Show resolved
Hide resolved
…wSAIQueryLoggerTest and test the metric update fix for that method
adelapena
approved these changes
Nov 13, 2025
adelapena
left a comment
adelapena
left a comment
There was a problem hiding this comment.
Looks good to me. I have left just a minor suggestion to reset QUERY_OPT_LEVEL.
test/distributed/org/apache/cassandra/distributed/test/sai/SlowSAIQueryLoggerTest.java
Show resolved
Hide resolved
… test work with the defaults
|
✔️ Build ds-cassandra-pr-gate/PR-2115 approved by ButlerApproved by Butler |
michaelsembwever
pushed a commit
that referenced
this pull request
Dec 8, 2025
… updated by ANN and generic OrderBy (#2115)
michaelsembwever
pushed a commit
that referenced
this pull request
Dec 8, 2025
… updated by ANN and generic OrderBy (#2115)
michaelsembwever
pushed a commit
that referenced
this pull request
Dec 9, 2025
… updated by ANN and generic OrderBy (#2115)
michaelsembwever
pushed a commit
that referenced
this pull request
Dec 9, 2025
… updated by ANN and generic OrderBy (#2115)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
What is the issue
...
SAI sstablesHit and segmentsHit metrics are not updated by ANN and generic ORDER BY
What does this PR fix and why was it fixed
...
Fix sstablesHit and segmentsHit metrics to be updated by ANN and generic OrderBy