CDB-22: Introduce disallowed write consistencies guardrail#5
CDB-22: Introduce disallowed write consistencies guardrail#5nastra merged 1 commit intodatastax:guardrailsfrom
Conversation
snazy
left a comment
snazy
left a comment
There was a problem hiding this comment.
Not a full review, but a few comments.
Generally, let's keep the number of changes as small as possible (i.e. no unnecessary changes to imports).
I assume, that this is mostly the dse-db guardrails copied+pasted into the OSS source tree.
I think that the name of the emulate_dbass_defaults is confusing, because nobody in the OSS world knows what "dbass" is and why it's here and what it emulates, although it actually changes things.
nastra
force-pushed
the
CDB-22
branch
3 times, most recently
from
3b25043 to
fbfed9d
Compare
nastra
force-pushed
the
CDB-22
branch
2 times, most recently
from
c91a910 to
bd1f702
Compare
There was a problem hiding this comment.
Since this flag won't make it into OSS we need to remove it and ask Jim to apply these directly.
There was a problem hiding this comment.
as discussed on Slack: We'll port guardrails "mostly" as they are in DSE and then later apply any additional refactoring that is required for OSS
tjake
left a comment
tjake
left a comment
There was a problem hiding this comment.
Main issue is we need to remove all the DBAAS defaults stuff.
Fix RowFilter for ann during network messaging
3 participants
Tests: https://app.circleci.com/pipelines/github/nastra/cassandra/63/workflows/48e511bf-dcf5-484c-ad54-d304e51f2ebb