Conversation
…3896 Required by CNDB-3170 and CNDB-4909. * Make DistributedSchema.keyspaces protected since it's accessed by CNDB.
jakubzytka
reviewed
Oct 11, 2022
| return builder().add(updated.values()).build(); | ||
| } | ||
|
|
||
| private Set<TableMetadata> getTablesOrderedByDependencies() |
There was a problem hiding this comment.
Set and ordered together? I don't understand
Author
There was a problem hiding this comment.
Good question. This is leftover from DSE where we traverse graph edges in order. All of this can be deleted, actually since we just need to iterate over this.
jakubzytka
reviewed
Oct 11, 2022
| public static final DistributedSchema EMPTY = new DistributedSchema(Keyspaces.none(), SchemaConstants.emptyVersion); | ||
|
|
||
| private final Keyspaces keyspaces; | ||
| protected final Keyspaces keyspaces; |
There was a problem hiding this comment.
NIT: I don't have a strong opinion, but I think that we are using getKeyspaces() in VersionedSchema (which extends this class)
Author
There was a problem hiding this comment.
Ah yes, I missed that. I see a new use of keyspaces came in with https://github.com/riptano/cndb/commit/8d9c63f377adadbf6a85fa3c55e0047bcd6af28d.
OK let's keep it consistent and use getKeyspaces() everywhere and I'll drop this part.
jakubzytka
approved these changes
Oct 11, 2022
jakubzytka
left a comment
jakubzytka
left a comment
There was a problem hiding this comment.
LGTM, but perhaps it makes sense to ask @jacek for a quick look?
|
Kudos, SonarCloud Quality Gate passed! |
Author
|
Merging this since Jacek is OOO for the rest of the week and the failures are unrelated. |
jacek-lewandowski
pushed a commit
that referenced
this pull request
Oct 17, 2022
#555) * STAR-1697: Port keyspace renaming (KeyspaceMetadata::rename) from DB-3896 Required by CNDB-3170 and CNDB-4909.
jacek-lewandowski
pushed a commit
that referenced
this pull request
Oct 18, 2022
#555) * STAR-1697: Port keyspace renaming (KeyspaceMetadata::rename) from DB-3896 Required by CNDB-3170 and CNDB-4909.
michaelsembwever
pushed a commit
that referenced
this pull request
Feb 10, 2026
michaelsembwever
pushed a commit
that referenced
this pull request
Feb 11, 2026
michaelsembwever
pushed a commit
that referenced
this pull request
Feb 12, 2026
michaelsembwever
pushed a commit
that referenced
this pull request
Feb 14, 2026
michaelsembwever
pushed a commit
that referenced
this pull request
Feb 16, 2026
#555) * STAR-1697: Port keyspace renaming (KeyspaceMetadata::rename) from DB-3896 Required by CNDB-3170 and CNDB-4909. (cherry picked from commit f74c1a6) (cherry picked from commit 6fb5012) (Rebase of commit 19770fb) ninjafix – STAR-1697: Port keyspace renaming (KeyspaceMetadata::rename) from DB to be squashed
michaelsembwever
pushed a commit
that referenced
this pull request
Feb 27, 2026
#555) * STAR-1697: Port keyspace renaming (KeyspaceMetadata::rename) from DB-3896 Required by CNDB-3170 and CNDB-4909. (cherry picked from commit f74c1a6) (cherry picked from commit 6fb5012) (Rebase of commit 19770fb) ninjafix – STAR-1697: Port keyspace renaming (KeyspaceMetadata::rename) from DB to be squashed
michaelsembwever
pushed a commit
that referenced
this pull request
Mar 2, 2026
#555) * STAR-1697: Port keyspace renaming (KeyspaceMetadata::rename) from DB-3896 Required by CNDB-3170 and CNDB-4909. (cherry picked from commit f74c1a6) (cherry picked from commit 6fb5012) (Rebase of commit 19770fb) ninjafix – STAR-1697: Port keyspace renaming (KeyspaceMetadata::rename) from DB to be squashed
michaelsembwever
pushed a commit
that referenced
this pull request
Mar 4, 2026
#555) * STAR-1697: Port keyspace renaming (KeyspaceMetadata::rename) from DB-3896 Required by CNDB-3170 and CNDB-4909. (cherry picked from commit f74c1a6) (cherry picked from commit 6fb5012) (Rebase of commit 19770fb) ninjafix – STAR-1697: Port keyspace renaming (KeyspaceMetadata::rename) from DB to be squashed
michaelsembwever
pushed a commit
that referenced
this pull request
Mar 5, 2026
#555) * STAR-1697: Port keyspace renaming (KeyspaceMetadata::rename) from DB-3896 Required by CNDB-3170 and CNDB-4909. (cherry picked from commit f74c1a6) (cherry picked from commit 6fb5012) (Rebase of commit 19770fb) ninjafix – STAR-1697: Port keyspace renaming (KeyspaceMetadata::rename) from DB to be squashed
michaelsembwever
pushed a commit
that referenced
this pull request
Mar 25, 2026
#555) * STAR-1697: Port keyspace renaming (KeyspaceMetadata::rename) from DB-3896 Required by CNDB-3170 and CNDB-4909. (cherry picked from commit f74c1a6) (cherry picked from commit 6fb5012) (Rebase of commit 19770fb) ninjafix – STAR-1697: Port keyspace renaming (KeyspaceMetadata::rename) from DB to be squashed
michaelsembwever
pushed a commit
that referenced
this pull request
Mar 27, 2026
#555) * STAR-1697: Port keyspace renaming (KeyspaceMetadata::rename) from DB-3896 Required by CNDB-3170 and CNDB-4909. (cherry picked from commit f74c1a6) (cherry picked from commit 6fb5012) (Rebase of commit 19770fb) ninjafix – STAR-1697: Port keyspace renaming (KeyspaceMetadata::rename) from DB to be squashed
michaelsembwever
pushed a commit
that referenced
this pull request
Apr 14, 2026
#555) * STAR-1697: Port keyspace renaming (KeyspaceMetadata::rename) from DB-3896 Required by CNDB-3170 and CNDB-4909. (cherry picked from commit f74c1a6) (cherry picked from commit 6fb5012) (Rebase of commit 19770fb) ninjafix – STAR-1697: Port keyspace renaming (KeyspaceMetadata::rename) from DB to be squashed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…3896
Required by CNDB-3170 and CNDB-4909.