Star 1864#601
Merged
ethan-brown2022 merged 28 commits intodatastax:ds-trunkfrom Apr 5, 2023
Merged
Conversation
|
There are a few test failures directly caused by the changes we made -- the tests should be adjusted to reflect the current operation. Also look at sonarcloud's output; one of the things we should do is replace |
|
Actually, it's better to remove the Please do remove the modifier, and add the comment "Protected by the synchronized block in UnifiedCompactionStrategy#getNextBackgroundTasks" to both fields, as well as to |
blambov
reviewed
Mar 10, 2023
blambov
approved these changes
Mar 21, 2023
blambov
left a comment
blambov
left a comment
There was a problem hiding this comment.
LGTM
No need to fix the cognitive complexity sonarcloud reports. These methods are trivial and just apply the same pattern to a lot of fields.
added 24 commits
April 3, 2023 07:47
The variable W is changed from an int to an array of ints "Ws" with length 32. Ws[0] is the scaling parameter for level 0, Ws[1] is the scaling parameter for level 1, etc. Read Amplification and Write Amplification are calculated using Ws[0]. If W would be replaced with candW, instead set Ws[0] to candW and update the other levels (Ws[0] becomes candW, Ws[1] becomes the previous Ws[0], Ws[2] becomes the previous Ws[1], ...) If W would remain the same, keep current Ws[0] and update the other levels (Ws[0] remains unchanged, Ws[1] becomes the previous Ws[0], etc.)
Added function to determine if a given compaction is adaptive.
…gh unified_compaction.max_adaptive_compactions
…mpactions = -1 for no limit.
example: candW = 4, Ws = {4, 4, 12, 16} --> Ws = {4, 4, 4, 16}
as a result, higher levels will be less prone to changes
…ith the new way of applying changes to W to each level
This was calculated as total processed divided by total time, which is not correct when operations do not start at the same time.
… it is reflected in the read latency. Read costs now include all sstables checked regardless of hit.
CostCalculator no longer has readMultiplier and writeMultipler since they are now included in CompactionStrategyOptions
…teCompactionStrategyOptions
- Removed survivalFactor from readCost calculation
- Changed DEFAULT_MAX_ADAPTIVE_COMPACTION from 2 to 5
…age Specification issue in TableMetrics.java
…e for compaction cost calculations
ethan-brown2022
force-pushed
the
STAR-1864
branch
from
53e1cf3 to
5bcaabe
Compare
djatnieks
pushed a commit
that referenced
this pull request
Aug 22, 2023
- Changes to W are applied to level 0 first, and applied to higher levels on future calls if the choice remains the same. - Added max_adaptive_compactions option that sets a limit on the number of concurrent "adaptive compactions" (compactions triggered by changing W). - Updated read costs to include all sstables checked regardless of hit. - Made readMultiplier and writeMultiplier configurable options (costs_read_multiplier and costs_write_multiplier) and changed default readMultiplier to 0.5. - Compaction costs are only updated if inputDiskSize > 0. (cherry picked from commit 7f34b7c) (cherry picked from commit 3b26eeb)
djatnieks
pushed a commit
that referenced
this pull request
Sep 12, 2023
- Changes to W are applied to level 0 first, and applied to higher levels on future calls if the choice remains the same. - Added max_adaptive_compactions option that sets a limit on the number of concurrent "adaptive compactions" (compactions triggered by changing W). - Updated read costs to include all sstables checked regardless of hit. - Made readMultiplier and writeMultiplier configurable options (costs_read_multiplier and costs_write_multiplier) and changed default readMultiplier to 0.5. - Compaction costs are only updated if inputDiskSize > 0. (cherry picked from commit 7f34b7c) (cherry picked from commit 3b26eeb)
djatnieks
pushed a commit
that referenced
this pull request
Feb 14, 2024
- Changes to W are applied to level 0 first, and applied to higher levels on future calls if the choice remains the same. - Added max_adaptive_compactions option that sets a limit on the number of concurrent "adaptive compactions" (compactions triggered by changing W). - Updated read costs to include all sstables checked regardless of hit. - Made readMultiplier and writeMultiplier configurable options (costs_read_multiplier and costs_write_multiplier) and changed default readMultiplier to 0.5. - Compaction costs are only updated if inputDiskSize > 0. (cherry picked from commit 7f34b7c) (cherry picked from commit 3b26eeb) # Conflicts: # src/java/org/apache/cassandra/db/SinglePartitionReadCommand.java # src/java/org/apache/cassandra/db/compaction/CompactionStrategyOptions.java # src/java/org/apache/cassandra/db/compaction/unified/AdaptiveController.java # src/java/org/apache/cassandra/db/compaction/unified/CostsCalculator.java # src/java/org/apache/cassandra/db/memtable/Flushing.java # test/unit/org/apache/cassandra/db/compaction/CompactionSimulationTest.java # test/unit/org/apache/cassandra/db/compaction/unified/CostsCalculatorTest.java
djatnieks
pushed a commit
that referenced
this pull request
Mar 29, 2024
- Changes to W are applied to level 0 first, and applied to higher levels on future calls if the choice remains the same. - Added max_adaptive_compactions option that sets a limit on the number of concurrent "adaptive compactions" (compactions triggered by changing W). - Updated read costs to include all sstables checked regardless of hit. - Made readMultiplier and writeMultiplier configurable options (costs_read_multiplier and costs_write_multiplier) and changed default readMultiplier to 0.5. - Compaction costs are only updated if inputDiskSize > 0. (cherry picked from commit 7f34b7c) (cherry picked from commit 3b26eeb) # Conflicts: # src/java/org/apache/cassandra/db/SinglePartitionReadCommand.java # src/java/org/apache/cassandra/db/compaction/CompactionStrategyOptions.java # src/java/org/apache/cassandra/db/compaction/unified/AdaptiveController.java # src/java/org/apache/cassandra/db/compaction/unified/CostsCalculator.java # src/java/org/apache/cassandra/db/memtable/Flushing.java # test/unit/org/apache/cassandra/db/compaction/CompactionSimulationTest.java # test/unit/org/apache/cassandra/db/compaction/unified/CostsCalculatorTest.java
djatnieks
pushed a commit
that referenced
this pull request
Apr 1, 2024
- Changes to W are applied to level 0 first, and applied to higher levels on future calls if the choice remains the same. - Added max_adaptive_compactions option that sets a limit on the number of concurrent "adaptive compactions" (compactions triggered by changing W). - Updated read costs to include all sstables checked regardless of hit. - Made readMultiplier and writeMultiplier configurable options (costs_read_multiplier and costs_write_multiplier) and changed default readMultiplier to 0.5. - Compaction costs are only updated if inputDiskSize > 0. (cherry picked from commit 7f34b7c) (cherry picked from commit 3b26eeb) # Conflicts: # src/java/org/apache/cassandra/db/SinglePartitionReadCommand.java # src/java/org/apache/cassandra/db/compaction/CompactionStrategyOptions.java # src/java/org/apache/cassandra/db/compaction/unified/AdaptiveController.java # src/java/org/apache/cassandra/db/compaction/unified/CostsCalculator.java # src/java/org/apache/cassandra/db/memtable/Flushing.java # test/unit/org/apache/cassandra/db/compaction/CompactionSimulationTest.java # test/unit/org/apache/cassandra/db/compaction/unified/CostsCalculatorTest.java
djatnieks
pushed a commit
that referenced
this pull request
Apr 16, 2024
- Changes to W are applied to level 0 first, and applied to higher levels on future calls if the choice remains the same. - Added max_adaptive_compactions option that sets a limit on the number of concurrent "adaptive compactions" (compactions triggered by changing W). - Updated read costs to include all sstables checked regardless of hit. - Made readMultiplier and writeMultiplier configurable options (costs_read_multiplier and costs_write_multiplier) and changed default readMultiplier to 0.5. - Compaction costs are only updated if inputDiskSize > 0. (cherry picked from commit 7f34b7c) (cherry picked from commit 3b26eeb) # Conflicts: # src/java/org/apache/cassandra/db/SinglePartitionReadCommand.java # src/java/org/apache/cassandra/db/compaction/CompactionStrategyOptions.java # src/java/org/apache/cassandra/db/compaction/unified/AdaptiveController.java # src/java/org/apache/cassandra/db/compaction/unified/CostsCalculator.java # src/java/org/apache/cassandra/db/memtable/Flushing.java # test/unit/org/apache/cassandra/db/compaction/CompactionSimulationTest.java # test/unit/org/apache/cassandra/db/compaction/unified/CostsCalculatorTest.java
djatnieks
pushed a commit
that referenced
this pull request
May 17, 2024
- Changes to W are applied to level 0 first, and applied to higher levels on future calls if the choice remains the same. - Added max_adaptive_compactions option that sets a limit on the number of concurrent "adaptive compactions" (compactions triggered by changing W). - Updated read costs to include all sstables checked regardless of hit. - Made readMultiplier and writeMultiplier configurable options (costs_read_multiplier and costs_write_multiplier) and changed default readMultiplier to 0.5. - Compaction costs are only updated if inputDiskSize > 0. (cherry picked from commit 7f34b7c) (cherry picked from commit 3b26eeb) # Conflicts: # src/java/org/apache/cassandra/db/SinglePartitionReadCommand.java # src/java/org/apache/cassandra/db/compaction/CompactionStrategyOptions.java # src/java/org/apache/cassandra/db/compaction/unified/AdaptiveController.java # src/java/org/apache/cassandra/db/compaction/unified/CostsCalculator.java # src/java/org/apache/cassandra/db/memtable/Flushing.java # test/unit/org/apache/cassandra/db/compaction/CompactionSimulationTest.java # test/unit/org/apache/cassandra/db/compaction/unified/CostsCalculatorTest.java
jacek-lewandowski
pushed a commit
that referenced
this pull request
Jul 17, 2024
- Changes to W are applied to level 0 first, and applied to higher levels on future calls if the choice remains the same. - Added max_adaptive_compactions option that sets a limit on the number of concurrent "adaptive compactions" (compactions triggered by changing W). - Updated read costs to include all sstables checked regardless of hit. - Made readMultiplier and writeMultiplier configurable options (costs_read_multiplier and costs_write_multiplier) and changed default readMultiplier to 0.5. - Compaction costs are only updated if inputDiskSize > 0. (cherry picked from commit 7f34b7c) (cherry picked from commit 3b26eeb) # Conflicts: # src/java/org/apache/cassandra/db/SinglePartitionReadCommand.java # src/java/org/apache/cassandra/db/compaction/CompactionStrategyOptions.java # src/java/org/apache/cassandra/db/compaction/unified/AdaptiveController.java # src/java/org/apache/cassandra/db/compaction/unified/CostsCalculator.java # src/java/org/apache/cassandra/db/memtable/Flushing.java # test/unit/org/apache/cassandra/db/compaction/CompactionSimulationTest.java # test/unit/org/apache/cassandra/db/compaction/unified/CostsCalculatorTest.java
djatnieks
pushed a commit
that referenced
this pull request
Jan 30, 2025
- Changes to W are applied to level 0 first, and applied to higher levels on future calls if the choice remains the same. - Added max_adaptive_compactions option that sets a limit on the number of concurrent "adaptive compactions" (compactions triggered by changing W). - Updated read costs to include all sstables checked regardless of hit. - Made readMultiplier and writeMultiplier configurable options (costs_read_multiplier and costs_write_multiplier) and changed default readMultiplier to 0.5. - Compaction costs are only updated if inputDiskSize > 0. (cherry picked from commit 7f34b7c) (cherry picked from commit 3b26eeb) # Conflicts: # src/java/org/apache/cassandra/db/SinglePartitionReadCommand.java # src/java/org/apache/cassandra/db/compaction/CompactionStrategyOptions.java # src/java/org/apache/cassandra/db/compaction/unified/AdaptiveController.java # src/java/org/apache/cassandra/db/compaction/unified/CostsCalculator.java # src/java/org/apache/cassandra/db/memtable/Flushing.java # test/unit/org/apache/cassandra/db/compaction/CompactionSimulationTest.java # test/unit/org/apache/cassandra/db/compaction/unified/CostsCalculatorTest.java
djatnieks
pushed a commit
that referenced
this pull request
May 18, 2025
- Changes to W are applied to level 0 first, and applied to higher levels on future calls if the choice remains the same. - Added max_adaptive_compactions option that sets a limit on the number of concurrent "adaptive compactions" (compactions triggered by changing W). - Updated read costs to include all sstables checked regardless of hit. - Made readMultiplier and writeMultiplier configurable options (costs_read_multiplier and costs_write_multiplier) and changed default readMultiplier to 0.5. - Compaction costs are only updated if inputDiskSize > 0. (cherry picked from commit 7f34b7c) (cherry picked from commit 3b26eeb) # Conflicts: # src/java/org/apache/cassandra/db/SinglePartitionReadCommand.java # src/java/org/apache/cassandra/db/compaction/CompactionStrategyOptions.java # src/java/org/apache/cassandra/db/compaction/unified/AdaptiveController.java # src/java/org/apache/cassandra/db/compaction/unified/CostsCalculator.java # src/java/org/apache/cassandra/db/memtable/Flushing.java # test/unit/org/apache/cassandra/db/compaction/CompactionSimulationTest.java # test/unit/org/apache/cassandra/db/compaction/unified/CostsCalculatorTest.java
michaelsembwever
pushed a commit
that referenced
this pull request
Feb 6, 2026
- Changes to W are applied to level 0 first, and applied to higher levels on future calls if the choice remains the same. - Added max_adaptive_compactions option that sets a limit on the number of concurrent "adaptive compactions" (compactions triggered by changing W). - Updated read costs to include all sstables checked regardless of hit. - Made readMultiplier and writeMultiplier configurable options (costs_read_multiplier and costs_write_multiplier) and changed default readMultiplier to 0.5. - Compaction costs are only updated if inputDiskSize > 0. (cherry picked from commit 7f34b7c) (cherry picked from commit 3b26eeb) # Conflicts: # src/java/org/apache/cassandra/db/SinglePartitionReadCommand.java # src/java/org/apache/cassandra/db/compaction/CompactionStrategyOptions.java # src/java/org/apache/cassandra/db/compaction/unified/AdaptiveController.java # src/java/org/apache/cassandra/db/compaction/unified/CostsCalculator.java # src/java/org/apache/cassandra/db/memtable/Flushing.java # test/unit/org/apache/cassandra/db/compaction/CompactionSimulationTest.java # test/unit/org/apache/cassandra/db/compaction/unified/CostsCalculatorTest.java
michaelsembwever
pushed a commit
that referenced
this pull request
Feb 10, 2026
- Changes to W are applied to level 0 first, and applied to higher levels on future calls if the choice remains the same. - Added max_adaptive_compactions option that sets a limit on the number of concurrent "adaptive compactions" (compactions triggered by changing W). - Updated read costs to include all sstables checked regardless of hit. - Made readMultiplier and writeMultiplier configurable options (costs_read_multiplier and costs_write_multiplier) and changed default readMultiplier to 0.5. - Compaction costs are only updated if inputDiskSize > 0. (cherry picked from commit 7f34b7c) (cherry picked from commit 3b26eeb) # Conflicts: # src/java/org/apache/cassandra/db/SinglePartitionReadCommand.java # src/java/org/apache/cassandra/db/compaction/CompactionStrategyOptions.java # src/java/org/apache/cassandra/db/compaction/unified/AdaptiveController.java # src/java/org/apache/cassandra/db/compaction/unified/CostsCalculator.java # src/java/org/apache/cassandra/db/memtable/Flushing.java # test/unit/org/apache/cassandra/db/compaction/CompactionSimulationTest.java # test/unit/org/apache/cassandra/db/compaction/unified/CostsCalculatorTest.java (Rebase of commit 8216f4f)
michaelsembwever
pushed a commit
that referenced
this pull request
Feb 11, 2026
- Changes to W are applied to level 0 first, and applied to higher levels on future calls if the choice remains the same. - Added max_adaptive_compactions option that sets a limit on the number of concurrent "adaptive compactions" (compactions triggered by changing W). - Updated read costs to include all sstables checked regardless of hit. - Made readMultiplier and writeMultiplier configurable options (costs_read_multiplier and costs_write_multiplier) and changed default readMultiplier to 0.5. - Compaction costs are only updated if inputDiskSize > 0. (cherry picked from commit 7f34b7c) (cherry picked from commit 3b26eeb) # Conflicts: # src/java/org/apache/cassandra/db/SinglePartitionReadCommand.java # src/java/org/apache/cassandra/db/compaction/CompactionStrategyOptions.java # src/java/org/apache/cassandra/db/compaction/unified/AdaptiveController.java # src/java/org/apache/cassandra/db/compaction/unified/CostsCalculator.java # src/java/org/apache/cassandra/db/memtable/Flushing.java # test/unit/org/apache/cassandra/db/compaction/CompactionSimulationTest.java # test/unit/org/apache/cassandra/db/compaction/unified/CostsCalculatorTest.java (Rebase of commit 8216f4f)
michaelsembwever
pushed a commit
that referenced
this pull request
Feb 12, 2026
- Changes to W are applied to level 0 first, and applied to higher levels on future calls if the choice remains the same. - Added max_adaptive_compactions option that sets a limit on the number of concurrent "adaptive compactions" (compactions triggered by changing W). - Updated read costs to include all sstables checked regardless of hit. - Made readMultiplier and writeMultiplier configurable options (costs_read_multiplier and costs_write_multiplier) and changed default readMultiplier to 0.5. - Compaction costs are only updated if inputDiskSize > 0. (cherry picked from commit 7f34b7c) (cherry picked from commit 3b26eeb) # Conflicts: # src/java/org/apache/cassandra/db/SinglePartitionReadCommand.java # src/java/org/apache/cassandra/db/compaction/CompactionStrategyOptions.java # src/java/org/apache/cassandra/db/compaction/unified/AdaptiveController.java # src/java/org/apache/cassandra/db/compaction/unified/CostsCalculator.java # src/java/org/apache/cassandra/db/memtable/Flushing.java # test/unit/org/apache/cassandra/db/compaction/CompactionSimulationTest.java # test/unit/org/apache/cassandra/db/compaction/unified/CostsCalculatorTest.java (Rebase of commit 8216f4f)
michaelsembwever
pushed a commit
that referenced
this pull request
Feb 14, 2026
- Changes to W are applied to level 0 first, and applied to higher levels on future calls if the choice remains the same. - Added max_adaptive_compactions option that sets a limit on the number of concurrent "adaptive compactions" (compactions triggered by changing W). - Updated read costs to include all sstables checked regardless of hit. - Made readMultiplier and writeMultiplier configurable options (costs_read_multiplier and costs_write_multiplier) and changed default readMultiplier to 0.5. - Compaction costs are only updated if inputDiskSize > 0. (cherry picked from commit 7f34b7c) (cherry picked from commit 3b26eeb) # Conflicts: # src/java/org/apache/cassandra/db/SinglePartitionReadCommand.java # src/java/org/apache/cassandra/db/compaction/CompactionStrategyOptions.java # src/java/org/apache/cassandra/db/compaction/unified/AdaptiveController.java # src/java/org/apache/cassandra/db/compaction/unified/CostsCalculator.java # src/java/org/apache/cassandra/db/memtable/Flushing.java # test/unit/org/apache/cassandra/db/compaction/CompactionSimulationTest.java # test/unit/org/apache/cassandra/db/compaction/unified/CostsCalculatorTest.java (Rebase of commit 8216f4f)
michaelsembwever
pushed a commit
that referenced
this pull request
Feb 16, 2026
- Changes to W are applied to level 0 first, and applied to higher levels on future calls if the choice remains the same. - Added max_adaptive_compactions option that sets a limit on the number of concurrent "adaptive compactions" (compactions triggered by changing W). - Updated read costs to include all sstables checked regardless of hit. - Made readMultiplier and writeMultiplier configurable options (costs_read_multiplier and costs_write_multiplier) and changed default readMultiplier to 0.5. - Compaction costs are only updated if inputDiskSize > 0. (cherry picked from commit 7f34b7c) (cherry picked from commit 3b26eeb) # Conflicts: # src/java/org/apache/cassandra/db/SinglePartitionReadCommand.java # src/java/org/apache/cassandra/db/compaction/CompactionStrategyOptions.java # src/java/org/apache/cassandra/db/compaction/unified/AdaptiveController.java # src/java/org/apache/cassandra/db/compaction/unified/CostsCalculator.java # src/java/org/apache/cassandra/db/memtable/Flushing.java # test/unit/org/apache/cassandra/db/compaction/CompactionSimulationTest.java # test/unit/org/apache/cassandra/db/compaction/unified/CostsCalculatorTest.java (Rebase of commit 8216f4f)
michaelsembwever
pushed a commit
that referenced
this pull request
Feb 27, 2026
- Changes to W are applied to level 0 first, and applied to higher levels on future calls if the choice remains the same. - Added max_adaptive_compactions option that sets a limit on the number of concurrent "adaptive compactions" (compactions triggered by changing W). - Updated read costs to include all sstables checked regardless of hit. - Made readMultiplier and writeMultiplier configurable options (costs_read_multiplier and costs_write_multiplier) and changed default readMultiplier to 0.5. - Compaction costs are only updated if inputDiskSize > 0. (cherry picked from commit 7f34b7c) (cherry picked from commit 3b26eeb) (Rebase of commit 8216f4f) STAR-1864 changed default readMultiplier from 0.5 to 1.0 (#609) * added Void type in Timer.java for testing * changed default readMultiplier to 1.0 instead of 0.5 * removed changes to Timer.java (cherry picked from commit 57013da) (cherry picked from commit f521a6a) (cherry picked from commit e24c809) (Rebase of commit 05fade6)
michaelsembwever
pushed a commit
that referenced
this pull request
Mar 2, 2026
- Changes to W are applied to level 0 first, and applied to higher levels on future calls if the choice remains the same. - Added max_adaptive_compactions option that sets a limit on the number of concurrent "adaptive compactions" (compactions triggered by changing W). - Updated read costs to include all sstables checked regardless of hit. - Made readMultiplier and writeMultiplier configurable options (costs_read_multiplier and costs_write_multiplier) and changed default readMultiplier to 0.5. - Compaction costs are only updated if inputDiskSize > 0. (cherry picked from commit 7f34b7c) (cherry picked from commit 3b26eeb) (Rebase of commit 8216f4f) STAR-1864 changed default readMultiplier from 0.5 to 1.0 (#609) * added Void type in Timer.java for testing * changed default readMultiplier to 1.0 instead of 0.5 * removed changes to Timer.java (cherry picked from commit 57013da) (cherry picked from commit f521a6a) (cherry picked from commit e24c809) (Rebase of commit 05fade6)
michaelsembwever
pushed a commit
that referenced
this pull request
Mar 4, 2026
- Changes to W are applied to level 0 first, and applied to higher levels on future calls if the choice remains the same. - Added max_adaptive_compactions option that sets a limit on the number of concurrent "adaptive compactions" (compactions triggered by changing W). - Updated read costs to include all sstables checked regardless of hit. - Made readMultiplier and writeMultiplier configurable options (costs_read_multiplier and costs_write_multiplier) and changed default readMultiplier to 0.5. - Compaction costs are only updated if inputDiskSize > 0. (cherry picked from commit 7f34b7c) (cherry picked from commit 3b26eeb) (Rebase of commit 8216f4f) STAR-1864 changed default readMultiplier from 0.5 to 1.0 (#609) * added Void type in Timer.java for testing * changed default readMultiplier to 1.0 instead of 0.5 * removed changes to Timer.java (cherry picked from commit 57013da) (cherry picked from commit f521a6a) (cherry picked from commit e24c809) (Rebase of commit 05fade6)
michaelsembwever
pushed a commit
that referenced
this pull request
Mar 5, 2026
- Changes to W are applied to level 0 first, and applied to higher levels on future calls if the choice remains the same. - Added max_adaptive_compactions option that sets a limit on the number of concurrent "adaptive compactions" (compactions triggered by changing W). - Updated read costs to include all sstables checked regardless of hit. - Made readMultiplier and writeMultiplier configurable options (costs_read_multiplier and costs_write_multiplier) and changed default readMultiplier to 0.5. - Compaction costs are only updated if inputDiskSize > 0. (cherry picked from commit 7f34b7c) (cherry picked from commit 3b26eeb) (Rebase of commit 8216f4f) STAR-1864 changed default readMultiplier from 0.5 to 1.0 (#609) * added Void type in Timer.java for testing * changed default readMultiplier to 1.0 instead of 0.5 * removed changes to Timer.java (cherry picked from commit 57013da) (cherry picked from commit f521a6a) (cherry picked from commit e24c809) (Rebase of commit 05fade6)
michaelsembwever
pushed a commit
that referenced
this pull request
Mar 25, 2026
- Changes to W are applied to level 0 first, and applied to higher levels on future calls if the choice remains the same. - Added max_adaptive_compactions option that sets a limit on the number of concurrent "adaptive compactions" (compactions triggered by changing W). - Updated read costs to include all sstables checked regardless of hit. - Made readMultiplier and writeMultiplier configurable options (costs_read_multiplier and costs_write_multiplier) and changed default readMultiplier to 0.5. - Compaction costs are only updated if inputDiskSize > 0. (cherry picked from commit 7f34b7c) (cherry picked from commit 3b26eeb) (Rebase of commit 8216f4f) STAR-1864 changed default readMultiplier from 0.5 to 1.0 (#609) * added Void type in Timer.java for testing * changed default readMultiplier to 1.0 instead of 0.5 * removed changes to Timer.java (cherry picked from commit 57013da) (cherry picked from commit f521a6a) (cherry picked from commit e24c809) (Rebase of commit 05fade6)
michaelsembwever
pushed a commit
that referenced
this pull request
Mar 27, 2026
- Changes to W are applied to level 0 first, and applied to higher levels on future calls if the choice remains the same. - Added max_adaptive_compactions option that sets a limit on the number of concurrent "adaptive compactions" (compactions triggered by changing W). - Updated read costs to include all sstables checked regardless of hit. - Made readMultiplier and writeMultiplier configurable options (costs_read_multiplier and costs_write_multiplier) and changed default readMultiplier to 0.5. - Compaction costs are only updated if inputDiskSize > 0. (cherry picked from commit 7f34b7c) (cherry picked from commit 3b26eeb) (Rebase of commit 8216f4f) STAR-1864 changed default readMultiplier from 0.5 to 1.0 (#609) * added Void type in Timer.java for testing * changed default readMultiplier to 1.0 instead of 0.5 * removed changes to Timer.java (cherry picked from commit 57013da) (cherry picked from commit f521a6a) (cherry picked from commit e24c809) (Rebase of commit 05fade6)
michaelsembwever
pushed a commit
that referenced
this pull request
Apr 14, 2026
- Changes to W are applied to level 0 first, and applied to higher levels on future calls if the choice remains the same. - Added max_adaptive_compactions option that sets a limit on the number of concurrent "adaptive compactions" (compactions triggered by changing W). - Updated read costs to include all sstables checked regardless of hit. - Made readMultiplier and writeMultiplier configurable options (costs_read_multiplier and costs_write_multiplier) and changed default readMultiplier to 0.5. - Compaction costs are only updated if inputDiskSize > 0. (cherry picked from commit 7f34b7c) (cherry picked from commit 3b26eeb) (Rebase of commit 8216f4f) STAR-1864 changed default readMultiplier from 0.5 to 1.0 (#609) * added Void type in Timer.java for testing * changed default readMultiplier to 1.0 instead of 0.5 * removed changes to Timer.java (cherry picked from commit 57013da) (cherry picked from commit f521a6a) (cherry picked from commit e24c809) (Rebase of commit 05fade6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.