fix duplicate changelog header#530
Closed
jshook wants to merge 1 commit into
Closed
Conversation
jshook
requested review from
MarkWolters,
marianotepper and
tlwillke
as code owners
Contributor
|
Before you submit for review:
If you did not complete any of these, then please explain below. |
Contributor
Author
|
I'll add a new PR which will avoid the breaking path |
eolivelli
added a commit
to eolivelli/jvector
that referenced
this pull request
May 11, 2026
Introduce a dedicated CompactionProgressListener functional interface and a compact(Path, CompactionProgressListener) overload so callers can track streaming compaction I/O progress without parsing log messages. The listener is called every ten batches (and at level completion) with (completedBatches, totalBatches) for each graph level processed. The existing compact(Path) delegate passes null and preserves full backward compatibility. Motivated by HerdDB issue datastax#530: the index-optimizer's GET /status endpoint showed batches_written=0 / pct_complete=0 throughout multi- minute streaming compaction runs because there was no hook to propagate the per-batch progress counters back to the HTTP status object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merely removes a duplicitous header which was added when I "updated" changelog. The changelog logic doesn't know how to reconcile deltas to the same labeled section yet.