Skip to content

CNDB-15469: Add NVQunatization::create method that takes global mean#549

Merged
marianotepper merged 2 commits intomainfrom
cndb-15469
Oct 22, 2025
Merged

CNDB-15469: Add NVQunatization::create method that takes global mean#549
marianotepper merged 2 commits intomainfrom
cndb-15469

Conversation

@michaeljmarshall
Copy link
Copy Markdown
Contributor

@michaeljmarshall michaeljmarshall commented Oct 17, 2025

In some applications, it will be better to compute the global mean iteratively at the time of insertion into the graph instead of when creating the NVQuantization object. Therefore, I propose adding a new create method that takes an already computed scaled global mean vector.

Because we update the existing compute method to call this new create method, the existing tests fully cover the new method.

This work is part of https://github.com/riptano/cndb/issues/15469.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 17, 2025

Before you submit for review:

  • Does your PR follow guidelines from CONTRIBUTIONS.md?
  • Did you summarize what this PR does clearly and concisely?
  • Did you include performance data for changes which may be performance impacting?
  • Did you include useful docs for any user-facing changes or features?
  • Did you include useful javadocs for developer oriented changes, explaining new concepts or key changes?
  • Did you trigger and review regression testing results against the base branch via Run Bench Main?
  • Did you adhere to the code formatting guidelines (TBD)
  • Did you group your changes for easy review, providing meaningful descriptions for each commit?
  • Did you ensure that all files contain the correct copyright header?

If you did not complete any of these, then please explain below.

@michaeljmarshall michaeljmarshall changed the title CNDB-15469: Add NVQunatization::compute method that takes global mean CNDB-15469: Add NVQunatization::create method that takes global mean Oct 17, 2025
Copy link
Copy Markdown
Contributor

@marianotepper marianotepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@jshook jshook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marianotepper marianotepper merged commit d20733b into main Oct 22, 2025
12 checks passed
@marianotepper marianotepper deleted the cndb-15469 branch October 22, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants