Skip to content

Virtualize and Modularize DataSetLoader logic #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jshook merged 3 commits into from
Jan 20, 2026
Merged

Virtualize and Modularize DataSetLoader logic #593

jshook merged 3 commits into from
Jan 20, 2026

Conversation

@jshook
Copy link
Contributor

@jshook jshook commented Dec 11, 2025

This is the next step-wise change to streamline dataset loading and usage. It does the following:

  • Virtualizes DataSetLoader, adds a central DataSets access point to simplify loading.
    • use Optional instead of checked IOExceptions
  • Separates and modularizes HDF5, MFD loaders and consolidate helper methods.
  • Organize dataset types into a package together.
  • Update callers, with minor cleanups.
  • Removes bench2d and its loader.

Virtualize and Modularize DataSetLoader logic
8c30186 
- virtualize DataSetLoader
- separate and modularize HDF5, MFD loaders and consolidate helper methods
- organize dataset types into a package together
- update callers, minor cleanups
- use Optional instead of checked IOExceptions
- add javadoc
- organize dataset classes together
- remove bench2d and loader
@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2025 •
edited by jshook
Loading

Before you submit for review:

  • Does your PR follow guidelines from CONTRIBUTIONS.md?
  • Did you summarize what this PR does clearly and concisely?
  • Did you include performance data for changes which may be performance impacting?
  • Did you include useful docs for any user-facing changes or features?
  • Did you include useful javadocs for developer oriented changes, explaining new concepts or key changes?
  • Did you trigger and review regression testing results against the base branch via Run Bench Main?
  • Did you adhere to the code formatting guidelines (TBD)
  • Did you group your changes for easy review, providing meaningful descriptions for each commit?
  • Did you ensure that all files contain the correct copyright header?

If you did not complete any of these, then please explain below.

MarkWolters
MarkWolters approved these changes Jan 16, 2026
View reviewed changes
Copy link
Contributor

@MarkWolters MarkWolters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments but they are not necessarily things that need to be addressed in this PR, overall looks good

marianotepper
marianotepper approved these changes Jan 20, 2026
View reviewed changes
Copy link
Collaborator

@marianotepper marianotepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart form a minor comment, this PR looks good.

@jshook jshook merged commit 3bd15e7 into main Jan 20, 2026
12 checks passed
@jshook jshook deleted the virtualize_datasetloader branch January 20, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marianotepper marianotepper marianotepper approved these changes

@MarkWolters MarkWolters MarkWolters approved these changes

@tlwillke tlwillke Awaiting requested review from tlwillke tlwillke is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jshook @marianotepper @MarkWolters