Skip to content

Comments

Multidirectory#634

Merged
MarkWolters merged 5 commits intomainfrom
multidirectory
Feb 24, 2026
Merged

Multidirectory#634
MarkWolters merged 5 commits intomainfrom
multidirectory

Conversation

@MarkWolters
Copy link
Contributor

@MarkWolters MarkWolters commented Feb 17, 2026

This PR expands the capability of the DiskUsageMonitor in the BenchYAML and autoBenchYAML testing applications to be able to monitor more than a single directory and to provide detailed information on disk used and number of new files for each directory monitored, as well as a summary of the total bytes used and number of new files across all monitored directories.

Although this allows DiskUsageMonitor to monitor an arbitrary number of directories in practice as of this PR it is used to monitor the work directory and the cache directory which contains indexes that may be reused for testing purposes.

example rollup summary at index construction time:

Disk Usage Summary Graph Index Build:
  [testDirectory]:
    Total Disk Used: 1.61 GB
    Total Files: 1
    Net Change: 1.61 GB, +1 files
  [indexCache]:
    Total Disk Used: 0 B
    Total Files: 0
    Net Change: 0 B, +0 files
  [Overall Total]:
    Total Disk Used: 1.61 GB
    Total Files: 1
    Net Change: 1.61 GB, +1 files
Index build time: 956.781921 seconds

@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2026

Before you submit for review:

  • Does your PR follow guidelines from CONTRIBUTIONS.md?
  • Did you summarize what this PR does clearly and concisely?
  • Did you include performance data for changes which may be performance impacting?
  • Did you include useful docs for any user-facing changes or features?
  • Did you include useful javadocs for developer oriented changes, explaining new concepts or key changes?
  • Did you trigger and review regression testing results against the base branch via Run Bench Main?
  • Did you adhere to the code formatting guidelines (TBD)
  • Did you group your changes for easy review, providing meaningful descriptions for each commit?
  • Did you ensure that all files contain the correct copyright header?

If you did not complete any of these, then please explain below.

@MarkWolters MarkWolters marked this pull request as ready for review February 18, 2026 16:14
Copy link
Contributor

@jshook jshook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

Copy link
Collaborator

@tlwillke tlwillke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Code changes look good. Looking forward to per-index disk usage in a future PR.

Copy link
Collaborator

@tlwillke tlwillke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Reviewed the changes and retested. Working as expected.

@MarkWolters MarkWolters merged commit 3ca3ce1 into main Feb 24, 2026
18 of 20 checks passed
@MarkWolters MarkWolters deleted the multidirectory branch February 24, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants