[fix][io] KCA: handle kafka sources that use commitRecord#176
Merged
dlg99 merged 1 commit intodatastax:2.10_dsfrom Apr 18, 2023
Merged
[fix][io] KCA: handle kafka sources that use commitRecord#176dlg99 merged 1 commit intodatastax:2.10_dsfrom
dlg99 merged 1 commit intodatastax:2.10_dsfrom
Conversation
eolivelli
reviewed
Apr 15, 2023
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
I agree with this approach.
Why do we need to add a configuration flag?
dlg99
force-pushed
the
kca-commitrecord_ds
branch
from
71fb2a9 to
a0ff03e
Compare
Collaborator
Author
|
@eolivelli I updated this a little. can't use commitRecord on fail, and removed configs. |
15 tasks
dlg99
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Support Kafka sources that use commitRecord() and do not implement commit()
Upstream PR: apache#20121
Modifications
added calls to commitRecord() in ack/fail
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: