Conversation
eccles
force-pushed
the
dev/eccles/synsation-yaml-story
branch
from
24674f7 to
69b43df
Compare
eccles
requested review from
JAG-UK,
Serhiy1,
henry739,
honourfish,
j-hartley,
landintrees,
leflambeur,
mmwilder26,
robinbryce,
waarg and
wp0pw
eccles
force-pushed
the
dev/eccles/synsation-yaml-story
branch
7 times, most recently
from
c60f8db to
f98c845
Compare
Contributor
|
The Jinja2 templating is really elegant - big fan |
Problem: Convert synsation samples to YAML story runner. Solution: New functest test_runner_synsation uses new locations creator and types of assets. The story is creted via Jinja2 template.... Signed-off-by: Paul Hewlett <phewlett76@gmail.com>
eccles
force-pushed
the
dev/eccles/synsation-yaml-story
branch
from
f98c845 to
69be544
Compare
henry739
approved these changes
Mar 15, 2022
Contributor
henry739
left a comment
henry739
left a comment
There was a problem hiding this comment.
This looks good to me, I just have a couple of questions. In general though, a little more context around some of the changes in the description could help reviews of this size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Convert synsation samples to YAML story runner.
Solution:
New functest test_runner_synsation uses new locations
creator and types of assets. The story is creted via Jinja2
template....
Signed-off-by: Paul Hewlett phewlett76@gmail.com