Conversation
eccles
requested review from
JAG-UK,
Serhiy1,
henry739,
honourfish,
j-hartley,
leflambeur and
mmwilder26
eccles
force-pushed
the
dev/eccles/attachment-mimetype
branch
3 times, most recently
from
c743e51 to
1c76aeb
Compare
Problem: Functest test_create_asset_khipu is skipped. Attachments default to image/jpg which does not allow for new autodetection of mime_type. Latest version of 'click' removed function used by 'black'. Solution: Remove skip decorator to test_create_asset_khipu functional test. Default content type for attachment upload is now None. Black version set to 22.3 or later. Signed-off-by: Paul Hewlett <phewlett76@gmail.com>
eccles
force-pushed
the
dev/eccles/attachment-mimetype
branch
from
1c76aeb to
2c1d4b7
Compare
eccles
changed the title
honourfish
approved these changes
Apr 1, 2022
robinbryce
approved these changes
Apr 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Functest test_create_asset_khipu is skipped.
Attachments default to image/jpg which does not allow
for new autodetection of mime_type.
Solution:
Remove skip decorator to test_create_asset_khipu functional
test.
Default content type for attachment upload is now None.
Signed-off-by: Paul Hewlett phewlett76@gmail.com