Handle errors more gracefully #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eccles
requested review from
CamrynCarter,
JAG-UK,
Serhiy1,
henry739,
honourfish,
leflambeur and
mmwilder26
This was
linked to
issues
May 16, 2022
Problem: Unclear error display when an illegal_url or bearer token is used. Solution: URL with trailing slash will immediately raise an exception. Illegal client_id and secret will generate an auth token that is None and this will raise an exception on first use. Logger handling is now fully documented with examples. Docs generation fixed (spelling plugin was preventing generation of html) Archivist unittests split into smaller files as original exceeded 1000 lines. Signed-off-by: Paul Hewlett <phewlett76@gmail.com>
eccles
force-pushed
the
dev/eccles/illegal-url
branch
from
be876f0 to
e1bbd16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Unclear error display when an illegal_url or bearer token is used.
Solution:
URL with trailing slash will immediately raise an exception.
Illegal client_id and secret will generate an auth token that is None
and this will raise an exception on first use.
Logger handling is now fully documented with examples.
Docs generation fixed (spelling plugin was preventing generation of
html)
Archivist unittests split into smaller files as original exceeded
1000 lines.
Signed-off-by: Paul Hewlett phewlett76@gmail.com