Misnamed arguments to subjects endpoint #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eccles
requested review from
JAG-UK,
Serhiy1,
henry739,
honourfish,
landintrees,
leflambeur,
robinbryce and
wp0pw
eccles
force-pushed
the
dev/eccles/subject-field-names
branch
3 times, most recently
from
e9912e5 to
feb5a2d
Compare
henry739
reviewed
Jul 13, 2022
Problem: Incorrectly named as plurali. Solution: Change wallet_pub_keys to wallet_pub_key Change tessera_pub_keys to tessera_pub_key Added missing SUBJECTS_DELETE action to story runner. Signed-off-by: Paul Hewlett <phewlett76@gmail.com>
eccles
force-pushed
the
dev/eccles/subject-field-names
branch
from
feb5a2d to
0f7ed1b
Compare
henry739
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Incorrectly named as plurali.
Solution:
Change wallet_pub_keys to wallet_pub_key
Change tessera_pub_keys to tessera_pub_key
Signed-off-by: Paul Hewlett phewlett76@gmail.com