Access policies count_matching methods #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eccles
requested review from
Serhiy1,
henry739,
honourfish,
j-hartley,
landintrees and
robinbryce
Problem: The backend does not support counting of matching assets or access_policies in the access_policy endpoint. Solution: Removed count_matching_assets() and count_matching_access_polices() methods in access_policies endpoint. Additionally made keyword arguments in update method mandatory. Signed-off-by: Paul Hewlett <phewlett76@gmail.com>
eccles
force-pushed
the
dev/eccles/remove-accesspolicies-count-matching
branch
from
aa43de1 to
691f26a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The backend does not support counting of matching assets or
access_policies in the access_policy endpoint.
Solution:
Removed count_matching_assets() and count_matching_access_polices()
methods in access_policies endpoint.
Signed-off-by: Paul Hewlett phewlett76@gmail.com