Skip to content

Conversation

@eccles
Copy link
Contributor

@eccles eccles commented Jul 8, 2022

Solution:
Example code for sharing an asset using access policies.
Functional test for asset sharing.

Signed-off-by: Paul Hewlett phewlett76@gmail.com

@eccles eccles force-pushed the dev/eccles/access-policies-examples branch 6 times, most recently from ecab836 to b6518f0 Compare July 12, 2022 14:01
Copy link
Contributor

@henry739 henry739 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some wording comments & suggestions - I still need to check out the notebook and tests

@henry739
Copy link
Contributor

@eccles I really like the Jupyter Notebook - Helps people get up and running quickly and allows them to experiment. We might want some extra words on the README about this - as well as auth token setup (and maybe some common sense guidance about not sharing / committing JWTs to source control.)

@eccles eccles force-pushed the dev/eccles/access-policies-examples branch from b6518f0 to 0a25299 Compare July 13, 2022 15:40
Copy link
Contributor

@henry739 henry739 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Solution:
Example code for sharing an asset using access policies.
Functional test for asset sharing.
Jupyter notebook for asset sharing.

Signed-off-by: Paul Hewlett <phewlett76@gmail.com>
@eccles eccles force-pushed the dev/eccles/access-policies-examples branch from c7d4308 to a894e7c Compare July 13, 2022 16:35
@eccles eccles merged commit cf8f1ac into main Jul 13, 2022
@eccles eccles deleted the dev/eccles/access-policies-examples branch July 13, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants