Fix type annotations and add workflows to facilitate them #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serhiy1
force-pushed
the
dev/serhiy/annotations
branch
from
448cc92 to
8c82193
Compare
Serhiy1
changed the title
eccles
suggested changes
Jul 25, 2022
Contributor
eccles
left a comment
eccles
left a comment
There was a problem hiding this comment.
LGTM - please do a
git pull --rebase origin main
git push -f
and I will approve
Problem: initial type annotation implementation was incomplete and has rotted Solution: Fix the type annotations and add task workflows to run it signed-off-by: serhiy1 <serhiy1@live.co.uk>
Serhiy1
force-pushed
the
dev/serhiy/annotations
branch
from
8c82193 to
da45e20
Compare
eccles
approved these changes
Jul 25, 2022
Contributor
eccles
left a comment
eccles
left a comment
There was a problem hiding this comment.
Pleaae do a 'Rebase and Merge#
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
initial type annotation implementation was incomplete and has rotted
Solution:
Fix the type annotations and add task workflows to run them
signed-off-by: serhiy1 serhiy1@live.co.uk