Duplicated Taskfile.yml #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serhiy1
approved these changes
Jul 26, 2022
Serhiy1
approved these changes
Jul 26, 2022
Problem: There is duplicated logic in 2 Taskfiles - one for inside the container and one for outside. Solution: Test the $USER variable for accepted values from a vscode or builder container and run cmds without 'docker run' prefixed o found. Additionally pre-install nodejs for the pyright type-checker so that pyright checks complete quickly. Signed-off-by: Paul Hewlett <phewlett76@gmail.com>
eccles
force-pushed
the
dev/paul/remove-duplicate-taskfile
branch
from
75b355c to
3ecc9ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
There is duplicated logic in 2 Taskfiles - one
for inside the container and one for outside.
Solution:
Test the $USER variable for accepted values from a vscode or
builder container and run cmds without 'docker run' prefixed
o found.
Additionally pre-install nodejs for the pyright type-checker so
that pyright checks complete quickly.
Signed-off-by: Paul Hewlett phewlett76@gmail.com