Skip to content

Use PEP517 instead of setup.py #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 12, 2022
Merged

Use PEP517 instead of setup.py #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d600b6
Use PEP517 instead of setup.py
eccles Aug 4, 2022
4c2fc6d
Configure pylint in pyproject.toml
eccles Aug 12, 2022
10df7c9
Coverage does not use pyproject.toml
eccles Aug 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@
"python.linting.pycodestylePath": "/usr/local/py-utils/bin/pycodestyle",
"python.linting.pydocstylePath": "/usr/local/py-utils/bin/pydocstyle",
"python.linting.pylintPath": "/usr/local/py-utils/bin/pylint",
"python.analysis.typeCheckingMode": "strict"
"python.analysis.typeCheckingMode": "basic",
"python.formatting.provider": "black"
},

// Add the IDs of extensions you want installed when the container is created.
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/python-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ jobs:
- name: Run integrity checks
run: |
./scripts/version.sh
pycodestyle --format=pylint setup.py archivist examples functests unittests
python3 -m pylint --rcfile=pylintrc setup.py archivist examples functests unittests
pycodestyle --format=pylint archivist examples functests unittests
python3 -m pylint archivist examples functests unittests
python3 -m pyright archivist
black archivist examples unittests functests
(cd docs && make clean && make html)
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/python-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
sudo rm -rf /var/lib/apt/lists/*
python3 -m pip install --upgrade pip
python3 -m pip install -r requirements-dev.txt
python3 -m pip install build setuptools wheel twine
python3 -m pip install setuptools wheel
- name: Build and publish
env:
TWINE_USERNAME: ${{ secrets.PYPI_USERNAME }}
Expand Down
11 changes: 4 additions & 7 deletions Taskfile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ tasks:
cmds:
- ./scripts/builder.sh python3 --version
- ./scripts/builder.sh python3 -m pyright archivist
- ./scripts/builder.sh pycodestyle --format=pylint setup.py archivist examples functests unittests
- ./scripts/builder.sh python3 -m pylint --rcfile=pylintrc setup.py archivist examples functests unittests
- ./scripts/builder.sh pycodestyle --format=pylint archivist examples functests unittests
- ./scripts/builder.sh python3 -m pylint archivist examples functests unittests

clean:
desc: Clean git repo
Expand All @@ -65,7 +65,7 @@ tasks:
desc: Format code using black
deps: [about]
cmds:
- ./scripts/builder.sh black setup.py archivist examples functests unittests
- ./scripts/builder.sh black archivist examples functests unittests

type-check:
desc: Runs the pyright type checker against the core archivst files
Expand Down Expand Up @@ -101,7 +101,4 @@ tasks:
desc: Builds python wheel package
deps: [about]
cmds:
- rm -rf *egg-info
- rm -rf build
- rm -f dist/*
- python3 setup.py bdist_wheel
- ./scripts/builder.sh ./scripts/wheel.sh
Loading