Dev/eccles/cache subclasses for efficiency#19
Merged
leflambeur merged 1 commit intomainfrom May 12, 2021
Merged
Conversation
Problem: On instantiation of archivist extra subclassesa are also instantiated even if not needed. Solution: Hide instantiation of subclasses behind a property. Signed-off-by: Paul Hewlett <phewlett76@gmail.com>
leflambeur
suggested changes
May 12, 2021
Contributor
leflambeur
left a comment
leflambeur
left a comment
There was a problem hiding this comment.
You're missing some code coverage in your tests, can you please add this back in
eccles
force-pushed
the
dev/eccles/cache-subclasses-for-efficiency
branch
from
e7f68e3 to
1d3cef4
Compare
ghost
deleted the
eccles
pushed a commit
that referenced
this pull request
Mar 22, 2022
…or-efficiency Dev/eccles/cache subclasses for efficiency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.