improve pipeline func tests task #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problem:
- The non 0 exit code from test Failures looks like script failures in the internal CD
- The test subjects count test is flakey due to other tests interfering with it
Solution:
- Set the exit code of pipeline_functests.sh to be 0
- fix the flakey test
signed-off-by:
serhiy <serhiy1@live.co.uk>
eccles
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem:
- The non 0 exit code from test Failures looks like script failures in the internal CD
- The test subjects count test is flakey due to other tests interfering with it
Solution:
- Set the exit code of pipeline_functests.sh to be 0
- fix the flakey test
signed-off-by:
serhiy serhiy1@live.co.uk