Skip to content

Conversation

@eccles
Copy link
Contributor

@eccles eccles commented Dec 9, 2022

Problem:
Example code is formatted and statically checked but not tested if correct.

Solution:
Notebooks have been introduced as a way of demonstrating correctness of example code. These notebooks will now replace example code in the documentation and will be tested.
This change implements one notebook and ensures that this is tested correctly and can be downloaded and executed by a customer.
The notebooks can be downloaded as a zip file and can be executed by the
user on her local development system.
Some notebooks already present are left untouched.

Signed-off-by: Paul Hewlett phewlett76@gmail.com

@eccles eccles force-pushed the dev/eccles/embed-notebook-into-docs branch 9 times, most recently from 932b467 to 5f757c0 Compare December 16, 2022 16:29
Problem:
Example code is formatted and statically checked but not tested if
correct.

Solution:
Notebooks have been introduced as a way of demonstrating correctness
of example code. These notebooks will now replace example
code in the documentation and will be tested.
This change implements one notebook and ensures that this is tested
correctly and can be downloaded and executed by a customer.
The notebooks can be downloaded as a zip file and can be executed by the
user on her local development system.
Some notebooks already present are left untouched.

Signed-off-by: Paul Hewlett <phewlett76@gmail.com>
Copy link

@waarg waarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eccles eccles merged commit f7d67bf into main Dec 19, 2022
@eccles eccles deleted the dev/eccles/embed-notebook-into-docs branch December 19, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants