Skip to content

#6860 switch to new attachments interface #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2023
Merged

#6860 switch to new attachments interface #218

merged 1 commit into from
Feb 7, 2023

Conversation

@wp0pw
Copy link
Contributor

@wp0pw wp0pw commented Feb 2, 2023

Use new shape for attachments in attributes.
Attachments are now top level attributes

"photo1": {
       "arc_attribute_type": "arc_attachment",
       "arc_blob_identity": "/archivist/v1/blobs/234234",
       "arc_file_name": "The photo.jpeg",
       "arc_blob_hash_alg": "sha256",
       "arc_blob_hash_value": "234532453453245",
       "something_else": "my favourite",
}

@wp0pw wp0pw requested review from JAG-UK and eccles February 2, 2023 14:49
henry739
henry739 reviewed Feb 2, 2023
View reviewed changes
henry739
henry739 reviewed Feb 2, 2023
View reviewed changes
henry739
henry739 reviewed Feb 2, 2023
View reviewed changes
eccles
eccles reviewed Feb 3, 2023
View reviewed changes
Copy link
Contributor

@eccles eccles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we checked the taskrunner and the functests ?
Do the functests still work ?

Otherwise LGTM

henry739
henry739 approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@henry739 henry739 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needs signoff from @eccles or @JAG-UK

@wp0pw
Update Attachment structure
b9d9350 
Problem:
Current attachment handling is not flexible and confusing and makes sharing attachments hard.

Solution:
Updated attachment structure to be more flexible and to allow easy sharing without any special handling.

Signed-off-by: Waldemar Parzonka <waldemar.parzonka@rkvst.com>
@wp0pw wp0pw merged commit 6b621b0 into datatrails:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JAG-UK JAG-UK Awaiting requested review from JAG-UK

2 more reviewers

@eccles eccles eccles left review comments

@henry739 henry739 henry739 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wp0pw @eccles @henry739