Document fonts are incorrect #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eccles
force-pushed
the
dev/eccles/-fix-static-fonts
branch
from
b83b218 to
13c2aac
Compare
Problem: Statically defined fonts were not available at python.rkvst.com. Solution: Fonts were retrieved using http instead of https which failed for external users but succeeded when run locally. Additionally fixed spurious pyright error. Signed-off-by: Paul Hewlett <phewlett76@gmail.com>
eccles
force-pushed
the
dev/eccles/-fix-static-fonts
branch
from
13c2aac to
48e0f86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Statically defined fonts were not available at python.rkvst.com.
Solution:
Fonts were retrieved using http instead of https which failed for external users but succeeded when run locally.