Merged
Conversation
Closed
eccles
requested review from
JAG-UK,
Serhiy1,
honourfish,
leflambeur and
wp0pw
Problem: The pythonSDK specified a fixed default page size instead of defaulting to whatever uostream has defined. Solution: Remove DEFAULT_PAGE_SIZE constants and set default page size to None. Signed-off-by: Paul Hewlett <phewlett76@gmail.com>
eccles
force-pushed
the
dev/eccles/default-page-size
branch
from
b89bc1a to
88a89d6
Compare
Serhiy1
approved these changes
Nov 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
The pythonSDK specified a fixed default page size instead of
defaulting to whatever uostream has defined.
Solution:
Remove DEFAULT_PAGE_SIZE constants and set default page size to
None.
Signed-off-by: Paul Hewlett phewlett76@gmail.com