Merged
Conversation
eccles
requested review from
Serhiy1,
henry739,
honourfish,
leflambeur and
wp0pw
eccles
force-pushed
the
dev/eccles/upload-sbom-confirm
branch
3 times, most recently
from
5058eb4 to
16530ab
Compare
Problem: Uploading an sbom can specify the type and the privacy setting. Solution: Added params optional argument that specifies a dict of "sbomType" and "privacy". Additionally added confim=True option to upload method to ensure that the metadata is written to the database before return. Upgraded coverage.py to version 6.2. Signed-off-by: Paul Hewlett <phewlett76@gmail.com>
eccles
force-pushed
the
dev/eccles/upload-sbom-confirm
branch
from
16530ab to
0914442
Compare
Serhiy1
approved these changes
Dec 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Uploading an sbom can specify the type and the privacy setting.
Solution:
Added params optional argument that specifies a dict of "sbom_type"
and "privacy".
Additionally added confim=True option to upload method to ensure that
the metadata is written to the database before return.
Signed-off-by: Paul Hewlett phewlett76@gmail.com