Merged
Conversation
eccles
requested review from
JAG-UK,
Serhiy1,
j-hartley,
leflambeur and
wp0pw
eccles
force-pushed
the
dev/eccles/sbom-download-viral-file
branch
from
7b0b802 to
d69df0f
Compare
Problem: An attachment that is not virus scanned or has a detected virus is normally not allowed to be downloaded. Solution: Add optional query params to the download method in the AssetsClient class that allows downloading bad attachment. Signed-off-by: Paul Hewlett <phewlett76@gmail.com>
eccles
force-pushed
the
dev/eccles/sbom-download-viral-file
branch
from
d69df0f to
8d04be1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
An attachment that is not virus scanned or has a detected virus
is normally not allowed to be downloaded.
Solution:
Add optional query params to the download method in the
AssetsClient class that allows downloading bad attachment.
Signed-off-by: Paul Hewlett phewlett76@gmail.com