Skip to content

Conversation

@puehringer
Copy link
Contributor

@puehringer puehringer commented Nov 14, 2022

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

  • Adds noAdditionals, defaultApp, and addWorkspaceRepos to the args of workspace-update script.

Screenshots

Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

@puehringer puehringer requested a review from a team as a code owner November 14, 2022 07:14
@puehringer puehringer force-pushed the mp/workspace_update_args branch from 755f71f to 606d4cf Compare November 14, 2022 07:14
@puehringer puehringer requested a review from a user November 14, 2022 07:15
@puehringer puehringer assigned ghost Nov 14, 2022
@puehringer puehringer added release: patch PR merge results in a new patch version type: feature New feature or request labels Nov 14, 2022
@ghost ghost merged commit 6e2583e into develop Nov 14, 2022
@ghost ghost deleted the mp/workspace_update_args branch November 14, 2022 07:52
@dvvanessastoiber dvvanessastoiber mentioned this pull request Nov 18, 2022
2 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: patch PR merge results in a new patch version type: feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant