Skip to content

Pin typescript-eslint to ~5.42.0 because of no-shadow false positives #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
puehringer merged 1 commit into from
Nov 15, 2022
Merged

Pin typescript-eslint to ~5.42.0 because of no-shadow false positives #15

puehringer merged 1 commit into from
Nov 15, 2022

Conversation

@puehringer
Copy link
Contributor

@puehringer puehringer commented Nov 15, 2022 •
edited
Loading

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

Screenshots

Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

@puehringer puehringer requested a review from a team as a code owner November 15, 2022 12:13
@puehringer puehringer force-pushed the mp/pin_typescript_eslint branch 3 times, most recently from 56e840b to 9d0b3c9 Compare November 15, 2022 12:31
@puehringer puehringer force-pushed the mp/pin_typescript_eslint branch from 9d0b3c9 to bb94219 Compare November 15, 2022 12:31
@puehringer puehringer added release: patch PR merge results in a new patch version type: bug Something isn't working labels Nov 15, 2022
@puehringer puehringer merged commit 6fa31ba into develop Nov 15, 2022
@puehringer puehringer deleted the mp/pin_typescript_eslint branch November 15, 2022 12:49
@dvvanessastoiber dvvanessastoiber mentioned this pull request Nov 18, 2022
Merged
2 tasks
puehringer added a commit that referenced this pull request Nov 18, 2022
@dvvanessastoiber @puehringer
Release 1.1.1 (#16)
7b6dc0f 
* prepare next dev version

* Added workspace-update args to command

* Pin typescript-eslint to ~5.42.0 because of no-shadow false positives (#15)

* prepare release 1.1.1

Co-authored-by: Michael Puehringer <michael.puehringer@datavisyn.io>
Co-authored-by: Anita Steiner <anita.steiner@datavisyn.io>
Co-authored-by: Michael Pühringer <51900829+puehringer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dvvanessastoiber dvvanessastoiber Awaiting requested review from dvvanessastoiber

Assignees

@dvvanessastoiber dvvanessastoiber

Labels

release: patch PR merge results in a new patch version type: bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@puehringer @dvvanessastoiber