Skip to content

Conversation

@puehringer
Copy link
Contributor

Closes list issues numbers here

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

Screenshots

Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

@puehringer puehringer marked this pull request as ready for review May 10, 2023 14:03
@puehringer puehringer requested a review from a team as a code owner May 10, 2023 14:03
@puehringer puehringer merged commit 3614b5c into develop May 16, 2023
@puehringer puehringer deleted the react18 branch May 16, 2023 07:14
@thinkh thinkh mentioned this pull request May 16, 2023
2 tasks
puehringer added a commit that referenced this pull request May 16, 2023
## Release notes

* Upgrade to TS5 #32 

### Release dependencies first

In case of dependent Phovea/TDP repositories follow [dependency
tree](https://wiki.datavisyn.io/phovea/fundamentals/development-process#dependency-hierarchy)
from the top:

 
### 🏁 Finish line

* [ ] Inform colleagues and customers about the release
* [ ] Celebrate the new release 🥳
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants