Release 4.0.1 #36
Merged
Release 4.0.1 #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#35) Pin sass-embedded to 1.62.0 to avoid "Cannot find module 'sass'" error. Also, remove the yarn.lock as it is not used transitively anyways. ``` ERROR in ./workspace.scss (./workspace.scss.webpack[javascript/auto]!=!../../node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[7].use[1]!../../node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[7].use[2]!../../node_modules/resolve-url-loader/index.js??ruleSet[1].rules[1].oneOf[7].use[3]!../../node_modules/sass-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[7].use[4]!./workspace.scss) Module build failed (from ../../node_modules/sass-loader/dist/cjs.js): Error: Cannot find module 'sass' Require stack: - /home/michael/workspaces/standalone_repos/visyn_scripts/node_modules/sass-loader/dist/utils.js - /home/michael/workspaces/standalone_repos/visyn_scripts/node_modules/sass-loader/dist/index.js - /home/michael/workspaces/standalone_repos/visyn_scripts/node_modules/sass-loader/dist/cjs.js - /home/michael/workspaces/standalone_repos/visyn_scripts/tests_fixtures/standalone_test/node_modules/loader-runner/lib/loadLoader.js - /home/michael/workspaces/standalone_repos/visyn_scripts/tests_fixtures/standalone_test/node_modules/loader-runner/lib/LoaderRunner.js - /home/michael/workspaces/standalone_repos/visyn_scripts/tests_fixtures/standalone_test/node_modules/webpack/lib/NormalModuleFactory.js - /home/michael/workspaces/standalone_repos/visyn_scripts/tests_fixtures/standalone_test/node_modules/webpack/lib/Compiler.js - /home/michael/workspaces/standalone_repos/visyn_scripts/tests_fixtures/standalone_test/node_modules/webpack/lib/webpack.js - /home/michael/workspaces/standalone_repos/visyn_scripts/tests_fixtures/standalone_test/node_modules/webpack/lib/index.js - /home/michael/workspaces/standalone_repos/visyn_scripts/tests_fixtures/standalone_test/node_modules/webpack-cli/lib/webpack-cli.js - /home/michael/workspaces/standalone_repos/visyn_scripts/tests_fixtures/standalone_test/node_modules/webpack-cli/lib/bootstrap.js - /home/michael/workspaces/standalone_repos/visyn_scripts/tests_fixtures/standalone_test/node_modules/webpack-cli/bin/cli.js - /home/michael/workspaces/standalone_repos/visyn_scripts/tests_fixtures/standalone_test/node_modules/webpack/bin/webpack.js at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15) at Function.Module._load (node:internal/modules/cjs/loader:778:27) at Module.require (node:internal/modules/cjs/loader:1005:19) at require (node:internal/modules/cjs/helpers:102:18) at getDefaultSassImplementation (/home/michael/workspaces/standalone_repos/visyn_scripts/node_modules/sass-loader/dist/utils.js:37:10) at getSassImplementation (/home/michael/workspaces/standalone_repos/visyn_scripts/node_modules/sass-loader/dist/utils.js:46:30) at Object.loader (/home/michael/workspaces/standalone_repos/visyn_scripts/node_modules/sass-loader/dist/index.js:23:55) ```
### Developer Checklist (Definition of Done) **Issue** - [x] All acceptance criteria from the issue are met - [x] Tested in latest Chrome/Firefox **UI/UX/Vis** - [ ] Requires UI/UX/Vis review - [ ] Reviewer(s) are notified (_tag assignees_) - [ ] Review has occurred (_link to notes_) - [ ] Feedback is included in this PR - [ ] Reviewer(s) approve of concept and design **Code** - [x] Branch is up-to-date with the branch to be merged with, i.e., develop - [x] Code is cleaned up and formatted - [x] Unit tests are written (frontend/backend if applicable) - [x] Integration tests are written (if applicable) **PR** - [x] Descriptive title for this pull request is provided (will be used for release notes later) - [x] Reviewer and assignees are defined - [x] Add type label (e.g., *bug*, *feature*) to this pull request - [x] Add release label (e.g., `release: minor`) to this PR following [semver](https://semver.org/) - [x] The PR is connected to the corresponding issue (via `Closes #...`) - [x] [Summary of changes](#summary-of-changes) is written ### Summary of changes - Destroy the current request on close to properly close any open SSE (server side events) sessions. Otherwise, the sessions will remain open and never be closed, causing issues with the reload process hanging infinitely. ### Screenshots ### Additional notes for the reviewer(s) - Thanks for creating this pull request 🤗
puehringer
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Release dependencies first
In case of dependent Phovea/TDP repositories follow dependency tree from the top:
🏁 Finish line