Skip to content

Conversation

@dvvanessastoiber
Copy link
Contributor

What's changed

dvvanessastoiber and others added 4 commits April 24, 2024 09:13
### Developer Checklist (Definition of Done)

**Issue**

- [x] All acceptance criteria from the issue are met
- [x] Tested in latest Chrome/Firefox

**UI/UX/Vis**

- [ ] Requires UI/UX/Vis review
  - [ ] Reviewer(s) are notified (_tag assignees_)
  - [ ] Review has occurred (_link to notes_)
  - [ ] Feedback is included in this PR
  - [ ] Reviewer(s) approve of concept and design

**Code**

- [x] Branch is up-to-date with the branch to be merged with, i.e.,
develop
- [x] Code is cleaned up and formatted
- [ ] Unit tests are written (frontend/backend if applicable)
- [ ] Integration tests are written (if applicable)

**PR**

- [x] Descriptive title for this pull request is provided (will be used
for release notes later)
- [x] Reviewer and assignees are defined
- [x] Add type label (e.g., *bug*, *feature*) to this pull request
- [x] Add release label (e.g., `release: minor`) to this PR following
[semver](https://semver.org/)
- [x] The PR is connected to the corresponding issue (via `Closes #...`)
- [x] [Summary of changes](#summary-of-changes) is written


### Summary of changes

- Disable `mangle` (alongside `compress`) as it creates wrong closures,
breaking dependencies like arquero. See attached issue in comment.

### Screenshots


### Additional notes for the reviewer(s)

-  
Thanks for creating this pull request 🤗
@dvvanessastoiber dvvanessastoiber self-assigned this Apr 24, 2024
@dvvanessastoiber dvvanessastoiber requested a review from a team as a code owner April 24, 2024 08:49
@puehringer puehringer merged commit 9295a01 into main Apr 24, 2024
@puehringer puehringer deleted the release-8.0.4 branch April 24, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants