Fix TypeError in _tzicalvtz._find_comp: comp[0] should be self._comps[0]#1454
Open
bysiber wants to merge 1 commit intodateutil:masterfrom
Open
Fix TypeError in _tzicalvtz._find_comp: comp[0] should be self._comps[0]#1454bysiber wants to merge 1 commit intodateutil:masterfrom
bysiber wants to merge 1 commit intodateutil:masterfrom
Conversation
In the for...else fallback when no standard component is found, the code uses comp[0] where comp is a _tzicalvtzcomp object (not subscriptable). The intent was to fall back to the first component in the list, i.e. self._comps[0].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_tzicalvtz._find_compraisesTypeErrorwhen falling back to the first timezone component in an iCalendar VTIMEZONE that has no STANDARD component.Problem
In the
for...elsefallback path (when no non-DST component is found), the code indexes intocomp— the loop variable — rather thanself._comps:After the
forloop completes withoutbreak,compis the last_tzicalvtzcompobject — a plain object with no__getitem__. The intent was clearly to fall back toself._comps[0](the first component in the list).This is triggered when querying a datetime that falls before any transition onset in a VTIMEZONE where all components are DST (no STANDARD entry).
Fix
Replace
comp[0]withself._comps[0].