Conversation
Update rand crate family to latest versions. Remove "rand/nightly" feature flag which no longer exists in rand 0.10. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Rename `Rng` → `RngExt` for extension method imports - Replace `from_os_rng()` with `rand::make_rng::<T>()` - Replace deprecated `choose_multiple()` with `sample()` Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the rand crate and its ecosystem from version 0.9 to 0.10, along with corresponding API changes. The rand 0.10 release introduced breaking changes that required code migration across the codebase, specifically changing from the Rng trait to RngExt for extension methods, replacing from_os_rng() with make_rng::<T>(), and renaming choose_multiple() to sample().
Changes:
- Updated
randfrom 0.9 to 0.10,rand_hcfrom 0.4 to 0.5, andrand_xoshirofrom 0.7 to 0.8 in Cargo.toml - Migrated all code to use
RngExttrait instead ofRngfor extension methods - Replaced
from_os_rng()calls withrand::make_rng::<T>()throughout the codebase - Updated
choose_multiple()method calls tosample()in cluster sampling code - Removed
rand/nightlyfeature flag (no longer available in rand 0.10)
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Updated rand dependencies to 0.10, rand_hc to 0.5, rand_xoshiro to 0.8; removed rand/nightly feature |
| Cargo.lock | Lock file updates reflecting new dependency versions and transitive dependencies (chacha20, cpufeatures 0.3.0) |
| src/main.rs | Changed import from rand::Rng to rand::RngExt |
| src/mainlite.rs | Changed import from rand::Rng to rand::RngExt |
| src/cmd/sort.rs | Changed import to RngExt; replaced from_os_rng() with make_rng::<T>() |
| src/cmd/select.rs | Replaced from_os_rng() with make_rng::<T>() |
| src/cmd/sample.rs | Added RngExt to imports (keeping Rng for trait bounds); replaced from_os_rng() with make_rng::<T>(); changed choose_multiple() to sample() |
| src/cmd/fetch.rs | Changed import from rand::Rng to rand::RngExt |
| src/cmd/fetchpost.rs | Changed import from rand::Rng to rand::RngExt |
| src/odhtcache.rs | Changed import from rand::Rng to rand::RngExt in test module |
| tests/tests.rs | Changed import from rand::Rng to rand::RngExt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.