Merged
Conversation
Update Cargo.toml to use atoi_simd = "0.18" and sysinfo = "0.38" (to stay in sync with upstream/polars). Cargo.lock was refreshed to reflect the resolved dependency versions.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
Contributor
There was a problem hiding this comment.
Pull request overview
Updates core dependencies used for fast numeric parsing and system introspection, adjusting call sites to match updated atoi_simd APIs across qsv’s CLI commands and utilities.
Changes:
- Bump
atoi_simdfrom0.17to0.18and updateparse/parse_poscall sites to use the new const-generic signatures. - Bump
sysinfofrom0.37.2to0.38. - Refresh
Cargo.lockto reflect the updated dependency graph.
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/util.rs | Updates env-var integer parsing to new atoi_simd::parse signature. |
| src/cmd/validate.rs | Updates integer parsing for JSON instance generation. |
| src/cmd/template.rs | Updates row number / human-count integer parsing. |
| src/cmd/stats.rs | Updates several env-var and sample integer parsing sites. |
| src/cmd/sort.rs | Updates byte-slice number parsing helpers to new atoi_simd signature. |
| src/cmd/schema.rs | Updates schema inference integer parsing. |
| src/cmd/sample.rs | Updates unix timestamp integer parsing attempt. |
| src/cmd/joinp.rs | Updates positive integer tolerance parsing (parse_pos). |
| src/cmd/frequency.rs | Updates env-var and stat-value integer parsing. |
| src/cmd/fetchpost.rs | Updates retry-after seconds parsing (parse_pos). |
| src/cmd/fetch.rs | Updates rate-limit header parsing (parse_pos). |
| src/cmd/extsort.rs | Updates position parsing from sorted temp lines. |
| src/cmd/excel.rs | Updates sheet index parsing. |
| src/cmd/datefmt.rs | Updates unix timestamp parsing helper. |
| Cargo.toml | Bumps atoi_simd and sysinfo dependency versions. |
| Cargo.lock | Records resolved updates (adds atoi_simd 0.18.1, sysinfo 0.38.4, etc.). |
[skip ci]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.