fix(apply,applydp): Thousands neg fractions, scope <NULL> to regex_replace

[jqnatividad]

Summary

Bug fixes surfaced during a code review of apply.rs, mirrored where applicable in applydp.rs.

Bugs fixed

• Thousands op ignored --replacement decimal separator for negative fractional numbers. num.fract() > 0.0 skipped them because f64::fract() preserves sign ((-1.5).fract() == -0.5). E.g. apply operations thousands col --formatstr space --replacement , on -1234.5 yielded -1 234.5 instead of -1 234,5. Now compares against != 0.0. (apply only — applydp has no Thousands op.)

• <NULL> --replacement was globally clearing flag_replacement for every op in the chain. A chained regex_replace,replace --replacement '<NULL>' would silently turn the replace into a deletion. NULL detection is now scoped to regex_replace only via a new regex_replacement parameter threaded into apply_operations / applydp_operations; replace and other ops see the user's literal --replacement value.

Behavior changes worth a changelog note

• Invalid user-supplied regex_replace --comparand now returns CliError::IncorrectUsage (exit code 2) instead of CliError::Other, with stderr prefixed by usage error: — consistent with every other user-input failure in validate_operations.
• regex_replace,replace --replacement <NULL> no longer silently nullifies the chained replace. If anyone relied on this, they should supply an explicit empty --replacement or drop the chained replace.

Refactors / cleanups

• Multi-column in-place transforms in both apply and applydp now rebuild each StringRecord once per row via a precomputed is_selected: Vec<bool> mask, instead of N times via replace_column_value (one rebuild per selected column).
• SmallVec::with_capacity(operations.len()) → SmallVec::new() in validate_operations so the inline-storage path is preserved for the common ≤4 ops case.
• apply::validate_operations: dropped unreachable OnceLock-error paths in favor of let _ = X.set(...) under the existing invokes guard; fail! / fail_clierror! for user-input errors are now consistently fail_incorrectusage_clierror!.

Test plan

• cargo test -F all_features --test tests apply — 71/71 pass (68 original + 1 multi-column rejection test + 2 new regression tests)
• cargo test --features datapusher_plus --test tests applydp — 32/32 pass (31 original + 1 new regression test)
• cargo build --locked --bin qsv -F all_features — clean
• cargo clippy -F all_features --bin qsv — no new warnings
• New regression tests:
  • apply_ops_thousands_eurostyle_negative_fraction — exercises negative fractional Thousands path
  • apply_ops_regex_replace_null_scoped_to_regex_replace
  • applydp_ops_regex_replace_null_scoped_to_regex_replace
• apply_ops_regex_replace_error / applydp_ops_regex_replace_error updated to expect the new usage error: prefix

🤖 Generated with Claude Code

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 29 complexity

Metric	Results
Complexity	29

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[Copilot]

Pull request overview

This PR fixes a couple of apply/applydp operation-chain edge cases (notably around regex_replace and numeric formatting), and includes small refactors aimed at improving the per-row transformation performance while keeping CLI error behavior consistent.

Changes:

• Fix apply thousands handling for negative fractional values so --replacement decimal separators are applied consistently.
• Scope <NULL> --replacement rewriting to regex_replace only (so it no longer silently changes the behavior of other chained ops like replace).
• Refactor multi-column in-place transforms to rebuild each StringRecord once per row using a precomputed selection mask; update/extend regression tests accordingly.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
tests/test_applydp.rs	Adds regression coverage for <NULL> scoping behavior; updates regex error expectation prefix.
tests/test_apply.rs	Adds regression coverage for <NULL> scoping and negative-fraction Thousands formatting; updates regex error expectation prefix.
src/cmd/applydp.rs	Scopes <NULL> handling to regex_replace; refactors in-place multi-column transforms to rebuild records once per row; improves incorrect-usage error classification for invalid regex.
src/cmd/apply.rs	Same <NULL> scoping + multi-column in-place rebuild refactor; fixes negative-fraction Thousands decimal separator handling; aligns certain user-input failures with IncorrectUsage.