Skip to content

Add ID function and other QOL changes.#1

Merged
datkat21 merged 2 commits intodatkat21:masterfrom
sl4shed:master
Nov 3, 2023
Merged

Add ID function and other QOL changes.#1
datkat21 merged 2 commits intodatkat21:masterfrom
sl4shed:master

Conversation

@sl4shed
Copy link
Copy Markdown
Contributor

@sl4shed sl4shed commented Nov 3, 2023

  • Added ID function:
  id(val) {
    if (this.elm.id != null) {
      throw Error("The element already has an ID.");
    }
    this.elm.id = val;
    return this;
  }
  • Renamed build.js to format.js to reduce confusion
  • Added build instructions to readme
  • Added documentation for the ID function.
  • Added a console.log() to the end of format.js

Copy link
Copy Markdown
Owner

@datkat21 datkat21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datkat21 datkat21 merged commit f0f6577 into datkat21:master Nov 3, 2023
@datkat21
Copy link
Copy Markdown
Owner

datkat21 commented Nov 3, 2023

For this to be in the next version did you increment the version number yet, if not I'll do that real quick

@datkat21
Copy link
Copy Markdown
Owner

datkat21 commented Nov 3, 2023

OK I'll update the version and push a new release to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants