feat: extract non-core plugins from app bundle to registry distribution#317
Merged
feat: extract non-core plugins from app bundle to registry distribution#317
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (10)
📝 WalkthroughWalkthroughThe PR extracts six plugins (MSSQL, MongoDB, Redis, XLSX export, MQL export, SQL import) from the bundled app into separately distributed, downloadable plugins; updates Xcode build phases to remove them; marks several plugins as downloadable in metadata; and propagates the change through docs, release skills, and CI/plugin build workflows. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
datlechin
force-pushed
the
extract-plugins-to-registry
branch
from
c40fa8a to
e58486f
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@CHANGELOG.md`:
- Line 12: Update the CHANGELOG.md entry that currently reads "Extracted MSSQL,
MongoDB, Redis, XLSX export, MQL export, and SQL import plugins from the app
bundle into separately distributed plugins, downloadable from the plugin
registry. MySQL, PostgreSQL, SQLite, CSV, JSON, and SQL export remain built-in"
by removing "SQLite" from the built-in plugins list so it correctly lists only
"MySQL, PostgreSQL, CSV, JSON, and SQL export"; locate the sentence in
CHANGELOG.md (the line beginning with "Extracted MSSQL, MongoDB...") and edit
that phrase to match the actual packaged plugins.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 770ee6fc-3a57-4fa1-996a-5f1dcbf449f1
📒 Files selected for processing (4)
CHANGELOG.mdTablePro.xcodeproj/project.pbxprojTablePro/Core/Plugins/PluginMetadataRegistry.swiftTablePro/Resources/Localizable.xcstrings
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/build-plugin.yml:
- Around line 96-110: The workflow currently assigns category: "database-driver"
for all plugins; update the mapping for the new TARGETs so XLSXExport and
MQLExport are published with an export category (e.g., "exporter") and SQLImport
is published with an import category (e.g., "importer") instead of
"database-driver". Locate where TARGET (XLSXExport, MQLExport, SQLImport) values
are set and ensure the manifest-generation step uses a CATEGORY variable (or
per-TARGET mapping) to write the correct category field into the registry
manifest rather than the hardcoded "database-driver".
In `@CLAUDE.md`:
- Around line 58-67: The plugin matrix table is missing the DuckDB entry; add a
row for DuckDBDriverPlugin with Database Types set to "DuckDB", the C Bridge set
to "CDuckDB" (or the appropriate DuckDB C bridge identifier), and Distribution
set to "Registry" so the table matches the distribution summary; update the
table row list including the unique symbol "DuckDBDriverPlugin" to ensure
consistency with the summary above.
In `@docs/customization/settings.mdx`:
- Around line 379-389: The plugins table in docs/customization/settings.mdx
omits DuckDB; update the table (the Plugin/Database Types/Default
Port/Distribution rows) to include a DuckDB entry (Database Types: DuckDB,
Default Port: --, Distribution: Registry) or alternatively add a clear note
above/below the table stating it is a partial list and that DuckDB is also
included in the registry-distributed drivers; reference the table rows for
MySQL/PostgreSQL/SQLite as examples when adding the DuckDB row or the
partial-list note.
In `@docs/vi/customization/settings.mdx`:
- Around line 377-386: The plugins table headed by "| Plugin | Loại Database |
Cổng Mặc định | Phân phối |" is missing DuckDB; either add a DuckDB row (e.g.,
"DuckDB | DuckDB | -- | Registry") to the table to match the current plugin list
or add a short parenthetical note under the table stating this is a
non-exhaustive list and DuckDB is available; update the table section in
settings.mdx accordingly so the documentation matches the actual plugins.
In `@docs/vi/development/architecture.mdx`:
- Around line 210-219: Add a missing DuckDB row to the plugin table: insert a
new table row with the plugin identifier DuckDBDriverPlugin, Database Types set
to DuckDB, C Bridge set to the project's DuckDB C API (e.g., libduckdb / C API)
and Distribution matching how DuckDB is shipped in the repo (likely Tích hợp
sẵn); locate the table around the existing rows like MySQLDriverPlugin,
PostgreSQLDriverPlugin, SQLiteDriverPlugin and add the DuckDBDriverPlugin entry
to keep the architecture docs in sync with the current drivers.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: aac5b4c4-a17d-4937-b91c-de3bd6b6d5be
📒 Files selected for processing (7)
.claude/skills/release/SKILL.md.github/workflows/build-plugin.ymlCLAUDE.mddocs/customization/settings.mdxdocs/development/architecture.mdxdocs/vi/customization/settings.mdxdocs/vi/development/architecture.mdx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isDownloadable: trueinPluginMetadataRegistryso the UI shows download prompts instead of treating them as built-inBuilt-in (5): MySQL, PostgreSQL, CSV, JSON, SQL export
Registry-distributed (9): MSSQL, MongoDB, Redis, XLSX, MQL, SQLImport, Oracle, ClickHouse, DuckDB
Test plan
TablePro.app/Contents/PlugIns/Summary by CodeRabbit
New Features
Changes
Documentation