Fix for record-comments CMA client targeting primary env instead of current.#140
Merged
marcelofinamorvieira merged 1 commit intomasterfrom Apr 14, 2026
Merged
Fix for record-comments CMA client targeting primary env instead of current.#140marcelofinamorvieira merged 1 commit intomasterfrom
marcelofinamorvieira merged 1 commit intomasterfrom
Conversation
…current environment buildClient() without an environment parameter defaults to the primary environment. When the primary env is write-protected, plugin installation in secondary environments fails because model creation targets the locked primary. Pass ctx.environment to all buildClient call sites. Also fix onBoot error notification using ctx.notice instead of ctx.alert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #139
Fix for record-comments CMA client targeting primary env instead of current.
buildClient() without an environment parameter defaults to the primary
environment. When the primary env is write-protected, plugin installation
in secondary environments fails because model creation targets the
locked primary. Pass ctx.environment to all buildClient call sites.
Also fix onBoot error notification using ctx.notice instead of ctx.alert.